Skip to content

chore: added missing implicit dependency on types to eslint-plugin #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2022
Merged

chore: added missing implicit dependency on types to eslint-plugin #4381

merged 3 commits into from
Jan 2, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds "@typescript-eslint/types" under implicitDependencies for the eslint-plugin package so that npx nx build website knows to build types and therefore copy ast-spec.ts.

Also adds a console.error in case the copy-ast-spec code throws for whatever reason.

@nx-cloud
Copy link

nx-cloud bot commented Dec 31, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 467cffd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 31, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 467cffd

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61d204563811e50008f4d435

😎 Browse the preview: https://deploy-preview-4381--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Dec 31, 2021 •
edited
Loading

Codecov Report

Merging #4381 (467cffd) into main (ccee1a2) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4381      +/-   ##
==========================================
- Coverage   94.61%   94.18%   -0.44%     
==========================================
  Files         147      294     +147     
  Lines        7841    10959    +3118     
  Branches     2507     3169     +662     
==========================================
+ Hits         7419    10322    +2903     
- Misses        233      383     +150     
- Partials      189      254      +65
Flag Coverage Δ
unittest 94.18% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/es2018.promise.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2019.array.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.full.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <0.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2015.core.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/variable/index.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2019.ts 100.00% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <0.00%> (ø)
... and 137 more

@bradzacher
Copy link
Member

I believe that this should be listed within the typscript-estree package instead of in the eslint-plugin package because that's where the copy script outputs to

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-estree/project.json

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jan 1, 2022
@bradzacher bradzacher changed the title fix: added missing implicit dependency on types to eslint-plugin chore: added missing implicit dependency on types to eslint-plugin Jan 1, 2022
bradzacher
bradzacher approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@bradzacher bradzacher enabled auto-merge (squash) January 2, 2022 20:11
@bradzacher bradzacher merged commit 6ae200c into typescript-eslint:main Jan 2, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the missing-implicit-types-dependency branch January 2, 2022 20:29
@Josh-Cena
Copy link
Member

Is this actually fixed...? Assuming that the recent PRs are based on the latest main HEAD, seems they are still failing for the same error?

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 16, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify deployments randomly failing
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena