feat(utils): expose ast-utils' helpers
#4503
Conversation
|
Thanks for the PR, @MichaelDeBoey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: 59271d1 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6216aeac43b62e000767d953 |
Codecov Report
@@ Coverage Diff @@
## main #4503 +/- ##
==========================================
- Coverage 94.26% 92.17% -2.10%
==========================================
Files 169 204 +35
Lines 9511 8860 -651
Branches 2973 2752 -221
==========================================
- Hits 8966 8167 -799
- Misses 322 484 +162
+ Partials 223 209 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
2945aad to
dae2fbb
Compare
|
@bradzacher could I ask for your help merging please? 😄 |
|
yeah automerge won't work unless all the required signals are green. So we just need to admin bypass instead of auto-merging |
Currently we're using a copy of
isNodeOfTypeineslint-plugin-testing-library.https://github.com/testing-library/eslint-plugin-testing-library/blob/main/lib/node-utils/is-node-of-type.ts#L6-L11
As the extraction in this codebase was originally copied from
eslint-plugin-testing-library(see #3677 & testing-library/eslint-plugin-testing-library#329), it seems logical to expose it here so other packages can use it whenever they want.