Skip to content

chore: remove naming convention todo from eslintrc #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

chore: remove naming convention todo from eslintrc #4651

merged 1 commit into from
Mar 9, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

I tried enabling it but there are a ton of AST-specific names such as TSQuery that don't match with it. We've lived this long without it and have a pretty informed maintainer team. 🤷

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: a81549d

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6227305ffa448e0007a152cf

😎 Browse the preview: https://deploy-preview-4651--typescript-eslint.netlify.app

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the remove-naming-convention-todo branch from fbf8283 to a81549d Compare March 8, 2022 10:30
@nx-cloud
Copy link

nx-cloud bot commented Mar 8, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit a81549d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 52 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Mar 9, 2022
@bradzacher bradzacher changed the title Remove naming convention todo chore: remove naming convention todo from eslintrc Mar 9, 2022
@bradzacher bradzacher merged commit 41bab2c into typescript-eslint:main Mar 9, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-naming-convention-todo branch March 9, 2022 02:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "TODO - enable"s from .eslintrc.js internally
2 participants
@JoshuaKGoldberg @bradzacher