feat: update to TypeScript 4.7-rc #4829

sosukesuzuki · 2022-04-17T10:14:54Z

PR Checklist

Addresses an existing open issue: fixes TypeScript 4.7 Support #4800
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

note: ~~api-extractor does not working on this PR, so d.ts rollup for ast-spec does not working too. So all CI is failing...~~ microsoft/rushstack#3349 has been fixed!

Updates to TypeScript 4.7
generate:lib
Avoid some type errors.
~~Avoid some syntax errors.~~
- [4.7-beta] Parsing failure for arrow function expr in conditional expr microsoft/TypeScript#48733

nx-cloud · 2022-04-17T10:14:56Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 04f3303. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-04-17T10:15:00Z

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-04-17T10:15:02Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`04f3303`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6282a753f4987800085fc434
😎 Deploy Preview	https://deploy-preview-4829--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/ast-spec/package.json

@@ -29,7 +29,7 @@
  "main": "dist/index.js",
  "types": "dist/index.d.ts",
  "scripts": {
-    "build": "tsc -b tsconfig.build.json && api-extractor run --local",
+    "build": "tsc -b tsconfig.build.json",


packages/utils/src/ast-utils/helpers.ts

codecov · 2022-05-05T05:55:32Z

Codecov Report

Merging #4829 (04f3303) into main (0ecd58f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4829      +/-   ##
==========================================
+ Coverage   91.73%   91.76%   +0.02%     
==========================================
  Files         227      229       +2     
  Lines       10592    10635      +43     
  Branches     3285     3293       +8     
==========================================
+ Hits         9717     9759      +42     
  Misses        592      592              
- Partials      283      284       +1

Flag	Coverage Δ
unittest	`91.76% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/no-unnecessary-type-arguments.ts	`98.14% <ø> (ø)`
packages/utils/src/ast-utils/helpers.ts	`68.18% <100.00%> (ø)`
packages/utils/src/eslint-utils/applyDefault.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin-tslint/src/rules/config.ts	`97.29% <0.00%> (ø)`
packages/eslint-plugin-tslint/src/custom-linter.ts	`100.00% <0.00%> (ø)`

…pes[TSTypeParameterInstantiation]`

bradzacher · 2022-05-16T19:35:07Z

We can look to merging this now as the RC has been released.

bradzacher

LGTM - thanks for this!

packages/utils/src/ast-utils/helpers.ts

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.23.0/5.25.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.23.0/5.25.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) ##### Bug Fixes - **eslint-plugin:** \[typedef] stop enforcing rule for assignment expressions ([#4958](typescript-eslint/typescript-eslint#4958)) ([04a216c](typescript-eslint/typescript-eslint@04a216c)) - **eslint-plugin:** strict config should not extend recommended ([#5005](typescript-eslint/typescript-eslint#5005)) ([05d71c2](typescript-eslint/typescript-eslint@05d71c2)) - **website:** correct Presets link to be Configs ([#5004](typescript-eslint/typescript-eslint#5004)) ([e18e91c](typescript-eslint/typescript-eslint@e18e91c)) ##### Features - **eslint-plugin:** \[no-empty-function] new allow option overrideMethods ([#4923](typescript-eslint/typescript-eslint#4923)) ([13c05ae](typescript-eslint/typescript-eslint@13c05ae)) - **eslint-plugin:** deprecate `no-duplicate-imports` in favour of `import/no-duplicates` ([#4973](typescript-eslint/typescript-eslint#4973)) ([1d2e41a](typescript-eslint/typescript-eslint@1d2e41a)) - update to TypeScript 4.7-rc ([#4829](typescript-eslint/typescript-eslint#4829)) ([6fe783c](typescript-eslint/typescript-eslint@6fe783c)) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) ##### Bug Fixes - **eslint-plugin:** \[array-type] in fixer add missing parens for constructor types [#4756](typescript-eslint/typescript-eslint#4756) ([#4971](typescript-eslint/typescript-eslint#4971)) ([0377070](typescript-eslint/typescript-eslint@0377070)) ##### Features - **eslint-plugin:** Add BigInt object type to default ban-types list ([#4970](typescript-eslint/typescript-eslint#4970)) ([1867728](typescript-eslint/typescript-eslint@1867728)) - **eslint-plugin:** add new 'strict' config ([#4706](typescript-eslint/typescript-eslint#4706)) ([4a500b2](typescript-eslint/typescript-eslint@4a500b2)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1357 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

sosukesuzuki commented Apr 17, 2022

View reviewed changes

packages/ast-spec/package.json Outdated

@@ -29,7 +29,7 @@

"main": "dist/index.js",

"types": "dist/index.d.ts",

"scripts": {

"build": "tsc -b tsconfig.build.json && api-extractor run --local",

"build": "tsc -b tsconfig.build.json",

This comment was marked as resolved.

Sign in to view

sosukesuzuki commented Apr 17, 2022

View reviewed changes

packages/utils/src/ast-utils/helpers.ts Show resolved Hide resolved

sosukesuzuki commented Apr 17, 2022

View reviewed changes

packages/utils/src/ast-utils/helpers.ts Show resolved Hide resolved

This was referenced Apr 17, 2022

feat(typescript-estree): extends constraints for infer #4830

Merged

feat: [4.7] support optional variance annotation #4831

Merged

feat(typescript-estree): typeof private identifiers #4832

Closed

jakebailey mentioned this pull request Apr 19, 2022

[4.7-beta] Parsing failure for arrow function expr in conditional expr microsoft/TypeScript#48733

Closed

bradzacher added the dependencies Issue about dependencies of the package label Apr 25, 2022

sosukesuzuki force-pushed the update-ts-4.7 branch from 04efb6c to d73e65b Compare May 5, 2022 05:38

sosukesuzuki force-pushed the update-ts-4.7 branch from 12b7da1 to df94340 Compare May 9, 2022 15:24

sosukesuzuki added 11 commits May 13, 2022 16:18

feat: update to TypeScript 4.7-beta

a808037

chore(ast-spec): remove api-extractor temporary

8e3dc0c

feat(types): run generate:lib

125a0a0

chore(typescript-estree): add ts.TypeQueryNode to `EstreeToTsNodeTy…

0695b33

…pes[TSTypeParameterInstantiation]`

fix(utils): fix type errors

40a5194

fix(eslint-plugin): avoid syntax errors

d74e91f

fix(eslint-plugin): avoid type errors

77ebf2c

test(typescript-estree): update snapshots

2a20e34

chore(ast-spec): revert removing api-extractor

7761028

feat: update to typescript@4.7.1-rc

7fdbf2d

chore(eslint-plugin): remove workaround for syntax errors

efc1b15

sosukesuzuki force-pushed the update-ts-4.7 branch from df94340 to efc1b15 Compare May 13, 2022 07:41

Merge branch 'main' into update-ts-4.7

04f3303

bradzacher marked this pull request as ready for review May 16, 2022 19:34

bradzacher approved these changes May 16, 2022

View reviewed changes

packages/utils/src/ast-utils/helpers.ts Show resolved Hide resolved

bradzacher changed the title ~~feat: update to TypeScript 4.7~~ feat: update to TypeScript 4.7-rc May 16, 2022

bradzacher enabled auto-merge (squash) May 16, 2022 19:37

bradzacher merged commit 6fe783c into typescript-eslint:main May 16, 2022

sosukesuzuki deleted the update-ts-4.7 branch May 17, 2022 15:13

bradzacher mentioned this pull request May 19, 2022

TypeScript 4.7 Support #4800

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update to TypeScript 4.7-rc #4829

feat: update to TypeScript 4.7-rc #4829

sosukesuzuki commented Apr 17, 2022 •

edited

Loading

nx-cloud bot commented Apr 17, 2022 •

edited

Loading

typescript-eslint bot commented Apr 17, 2022

netlify bot commented Apr 17, 2022 •

edited

Loading

This comment was marked as resolved.

codecov bot commented May 5, 2022 •

edited

Loading

bradzacher commented May 16, 2022

bradzacher left a comment

feat: update to TypeScript 4.7-rc #4829

feat: update to TypeScript 4.7-rc #4829

Conversation

sosukesuzuki commented Apr 17, 2022 • edited Loading

PR Checklist

Overview

nx-cloud bot commented Apr 17, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Apr 17, 2022

netlify bot commented Apr 17, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

This comment was marked as resolved.

codecov bot commented May 5, 2022 • edited Loading

Codecov Report

bradzacher commented May 16, 2022

bradzacher left a comment

Choose a reason for hiding this comment

sosukesuzuki commented Apr 17, 2022 •

edited

Loading

nx-cloud bot commented Apr 17, 2022 •

edited

Loading

netlify bot commented Apr 17, 2022 •

edited

Loading

codecov bot commented May 5, 2022 •

edited

Loading