Skip to content

feat: bump dependency ranges to TypeScript 4.7 #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2022
Merged

feat: bump dependency ranges to TypeScript 4.7 #5082

merged 2 commits into from
May 26, 2022

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

TS 4.7 has been released 🎉

https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/

@nx-cloud
Copy link

nx-cloud bot commented May 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0fa1585. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 26, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0fa1585
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/628fb0cc06c4980009af61bf
😎 Deploy Preview https://deploy-preview-5082--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

armano2
armano2 previously approved these changes May 26, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #5082 (0fa1585) into main (1fb31a4) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5082      +/-   ##
==========================================
+ Coverage   91.32%   91.70%   +0.37%     
==========================================
  Files         132      360     +228     
  Lines        1487    12174   +10687     
  Branches      224     3530    +3306     
==========================================
+ Hits         1358    11164    +9806     
- Misses         65      661     +596     
- Partials       64      349     +285
Flag Coverage Δ
unittest 91.70% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/strict.ts 100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 98.35% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 94.64% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 83.33% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-implicit-any-catch.ts 84.61% <0.00%> (ø)
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Scope.ts 100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/no-unnecessary-type-arguments.ts 98.14% <0.00%> (ø)
... and 218 more

bradzacher
bradzacher requested changes May 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clean up the version range matcher in typescript-estree as well to remove the RC version.

@bradzacher bradzacher added dependencies Issue about dependencies of the package enhancement New feature or request labels May 26, 2022
@bradzacher bradzacher changed the title feat: update to TypeScript 4.7 feat: bump dependency ranges to TypeScript 4.7 May 26, 2022
@armano2 armano2 self-requested a review May 26, 2022 16:03
@sosukesuzuki
Copy link
Contributor Author

0fa1585 👍

@brendankenny brendankenny mentioned this pull request May 26, 2022
Merged
bradzacher
bradzacher approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bradzacher bradzacher merged commit c4310b1 into typescript-eslint:main May 26, 2022
@sosukesuzuki sosukesuzuki deleted the update-ts branch May 26, 2022 19:16
@Hazmi35 Hazmi35 mentioned this pull request May 31, 2022
Merged
3 tasks
@brendankenny brendankenny mentioned this pull request Jun 10, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@armano2 armano2 Awaiting requested review from armano2

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 4.7 Support
3 participants
@sosukesuzuki @armano2 @bradzacher