fix(eslint-plugin): [space-infix-ops] correct PropertyDefinition with typeAnnotation #5113
Conversation
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #5113 +/- ##
==========================================
+ Coverage 91.70% 93.83% +2.12%
==========================================
Files 362 286 -76
Lines 12181 9838 -2343
Branches 3530 2939 -591
==========================================
- Hits 11171 9231 -1940
+ Misses 661 328 -333
+ Partials 349 279 -70
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
As mentioned here at #5133 (comment), most of the false positives have been eliminated after I used the version that includes the fix, but the code that contains the type Foo<T> = T extends { bar: string } ? string : number
^type Foo<T> = T extends (bar: string) => void ? string : number
^ |
i filled new issue for this bug #5134 |
|
in version type Foo<T extends (...args: any[]) => any> = T;
^ |
|
As per our contributing guidelines - PRs are not the place to discuss issues. Locking. |
PR Checklist
Overview
correct seelcting last node of PropertyDefinition when
typeAnnotationis presentregression fix for #5041
/^[=|?|:]$/.test(token.value)