Skip to content

chore(website): multiple fixes to rule docs generation #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

  1. Allows interpolating inline code
  2. Reliably removes the notice; currently some rules don't have their notice removed, for some reason... (e.g. https://typescript-eslint.io/rules/comma-dangle)

@nx-cloud
Copy link

nx-cloud bot commented Jul 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 621ae05. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 23, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 621ae05
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62dbff7545f46d0008ea0b2d
😎 Deploy Preview https://deploy-preview-5365--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #5365 (621ae05) into main (2588e9e) will decrease coverage by 2.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5365      +/-   ##
==========================================
- Coverage   93.77%   91.36%   -2.42%     
==========================================
  Files         287      132     -155     
  Lines        9886     1494    -8392     
  Branches     2961      226    -2735     
==========================================
- Hits         9271     1365    -7906     
+ Misses        335       65     -270     
+ Partials      280       64     -216     
Flag Coverage Δ
unittest 91.36% <ø> (-2.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts
packages/eslint-plugin/src/rules/no-type-alias.ts
...plugin/src/rules/naming-convention-utils/schema.ts
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts
packages/eslint-plugin/src/configs/all.ts
...rc/rules/no-unnecessary-boolean-literal-compare.ts
...ackages/eslint-plugin/src/rules/member-ordering.ts
...lugin/src/rules/padding-line-between-statements.ts
packages/eslint-plugin/src/rules/comma-dangle.ts
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts
... and 145 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks @Josh-Cena! 🙏

@JoshuaKGoldberg JoshuaKGoldberg merged commit 78823cc into typescript-eslint:main Jul 23, 2022
@Josh-Cena Josh-Cena deleted the fix-desc branch July 23, 2022 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants