From e40366d65b866e6e73f5f952161fa356c0f25b4e Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 23 Aug 2022 09:48:29 -0400 Subject: [PATCH 1/2] chore: fail tests that log to the console --- jest.config.base.js | 1 + package.json | 1 + packages/ast-spec/jest.config.js | 10 ++++++++-- packages/scope-manager/jest.config.js | 10 ++++++++-- yarn.lock | 5 +++++ 5 files changed, 23 insertions(+), 4 deletions(-) diff --git a/jest.config.base.js b/jest.config.base.js index b94573bf7196..707c023f2695 100644 --- a/jest.config.base.js +++ b/jest.config.base.js @@ -19,6 +19,7 @@ module.exports = { 'node', ], resolver: '/../../tests/jest-resolver.js', + setupFilesAfterEnv: ['console-fail-test/setup.js'], testRegex: ['./tests/.+\\.test\\.ts$', './tests/.+\\.spec\\.ts$'], transform: { '^.+\\.(t|j)sx?$': [ diff --git a/package.json b/package.json index 0cb1d2997455..a16fd3e1b409 100644 --- a/package.json +++ b/package.json @@ -73,6 +73,7 @@ "@types/rimraf": "^3.0.2", "@types/semver": "^7.3.9", "@types/tmp": "^0.2.3", + "console-fail-test": "^0.1.6", "cross-env": "^7.0.3", "cross-fetch": "^3.1.5", "cspell": "^5.20.0", diff --git a/packages/ast-spec/jest.config.js b/packages/ast-spec/jest.config.js index eeae64cb5dd4..6b927c0166bd 100644 --- a/packages/ast-spec/jest.config.js +++ b/packages/ast-spec/jest.config.js @@ -1,9 +1,15 @@ 'use strict'; // @ts-check + +const baseConfig = require('../../jest.config.base.js'); + /** @type {import('@jest/types').Config.InitialOptions} */ module.exports = { - ...require('../../jest.config.base.js'), + ...baseConfig, collectCoverage: false, - setupFilesAfterEnv: ['./tests/util/setupJest.ts'], + setupFilesAfterEnv: [ + ...baseConfig.setupFilesAfterEnv, + './tests/util/setupJest.ts', + ], }; diff --git a/packages/scope-manager/jest.config.js b/packages/scope-manager/jest.config.js index 9148e4d46fb7..e9aff2600f8e 100644 --- a/packages/scope-manager/jest.config.js +++ b/packages/scope-manager/jest.config.js @@ -1,8 +1,14 @@ 'use strict'; // @ts-check + +const baseConfig = require('../../jest.config.base.js'); + /** @type {import('@jest/types').Config.InitialOptions} */ module.exports = { - ...require('../../jest.config.base.js'), - setupFilesAfterEnv: ['./tests/util/serializers/index.ts'], + ...baseConfig, + setupFilesAfterEnv: [ + ...baseConfig.setupFilesAfterEnv, + './tests/util/serializers/index.ts', + ], }; diff --git a/yarn.lock b/yarn.lock index 505364bd9bae..8edc5a9a6ac3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5895,6 +5895,11 @@ console-control-strings@^1.1.0: resolved "https://registry.yarnpkg.com/console-control-strings/-/console-control-strings-1.1.0.tgz#3d7cf4464db6446ea644bf4b39507f9851008e8e" integrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4= +console-fail-test@^0.1.6: + version "0.1.6" + resolved "https://registry.yarnpkg.com/console-fail-test/-/console-fail-test-0.1.6.tgz#cbe953e784f73b9e821861bdf42d88f9ff57cde8" + integrity sha512-ZFUBOmebQxkEwFTKIjPMzwE0wZcvZPxBo0Bjg2kIdcupLUquEL8BtdwXGmUpf9tFGGL+2SvRlZRHCj+qx2Mzqw== + content-disposition@0.5.2: version "0.5.2" resolved "https://registry.yarnpkg.com/content-disposition/-/content-disposition-0.5.2.tgz#0cf68bb9ddf5f2be7961c3a85178cb85dba78cb4" From d4aae198f6c3cc3af3899f437234b822959c4c00 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 23 Aug 2022 11:14:59 -0400 Subject: [PATCH 2/2] console-fail-test@0.1.7 --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index a16fd3e1b409..036dd42f60dc 100644 --- a/package.json +++ b/package.json @@ -73,7 +73,7 @@ "@types/rimraf": "^3.0.2", "@types/semver": "^7.3.9", "@types/tmp": "^0.2.3", - "console-fail-test": "^0.1.6", + "console-fail-test": "^0.1.7", "cross-env": "^7.0.3", "cross-fetch": "^3.1.5", "cspell": "^5.20.0", diff --git a/yarn.lock b/yarn.lock index 8edc5a9a6ac3..cd67a8bb7a36 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5895,10 +5895,10 @@ console-control-strings@^1.1.0: resolved "https://registry.yarnpkg.com/console-control-strings/-/console-control-strings-1.1.0.tgz#3d7cf4464db6446ea644bf4b39507f9851008e8e" integrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4= -console-fail-test@^0.1.6: - version "0.1.6" - resolved "https://registry.yarnpkg.com/console-fail-test/-/console-fail-test-0.1.6.tgz#cbe953e784f73b9e821861bdf42d88f9ff57cde8" - integrity sha512-ZFUBOmebQxkEwFTKIjPMzwE0wZcvZPxBo0Bjg2kIdcupLUquEL8BtdwXGmUpf9tFGGL+2SvRlZRHCj+qx2Mzqw== +console-fail-test@^0.1.7: + version "0.1.7" + resolved "https://registry.yarnpkg.com/console-fail-test/-/console-fail-test-0.1.7.tgz#f21ee5f944fb42c0d176a56c5b4744cb2f8d86c8" + integrity sha512-WZ9unWXJSqDGMt/06wOSPNHwAIAdIJvhgSD2MepJHG5B7b3PD3b8q0NMpaqegGmGFgZUiru+0xEsyvpvg/CM+A== content-disposition@0.5.2: version "0.5.2"