From c22c4f642b06d643acb9119a2c257878423a7426 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 9 Sep 2022 09:05:17 +1000 Subject: [PATCH 1/7] chore: add .github/replies.yml --- .github/replies.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/replies.yml diff --git a/.github/replies.yml b/.github/replies.yml new file mode 100644 index 000000000000..8146ce6e056f --- /dev/null +++ b/.github/replies.yml @@ -0,0 +1,5 @@ +replies: + - body: | + Maury meme: You checked 'I have searched for related issues'. A cursory issue search related issues determined that was a lie.\ + Dup of #. Next time, please use the search 🙂. + name: Clearly Duplicate Issue From d1b2c8e04b9937bac6adb92544b0646903e521bc Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 9 Sep 2022 09:10:06 +1000 Subject: [PATCH 2/7] Add a thanks --- .github/replies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/replies.yml b/.github/replies.yml index 8146ce6e056f..ce9f063b3117 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -1,5 +1,5 @@ replies: - body: | Maury meme: You checked 'I have searched for related issues'. A cursory issue search related issues determined that was a lie.\ - Dup of #. Next time, please use the search 🙂. + Thanks for posting, but this is a duplicate of #. Next time, please use the search 🙂. name: Clearly Duplicate Issue From 1e98836a5074ea06d47752736b4bfa196a3675b2 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sat, 10 Sep 2022 09:43:58 +1000 Subject: [PATCH 3/7] Bump for Updates --- .github/replies.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/replies.yml b/.github/replies.yml index ce9f063b3117..567130996ba2 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -3,3 +3,13 @@ replies: Maury meme: You checked 'I have searched for related issues'. A cursory issue search related issues determined that was a lie.\ Thanks for posting, but this is a duplicate of #. Next time, please use the search 🙂. name: Clearly Duplicate Issue + - body: | + With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.\ + \ + We are a community run project. The volunteer maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues will not progress unless a member of the community steps up and champions it.\ + \ + If this issue is important to you - consider being that champion.\ + \ + If not - please just subscribe to the issue and wait patiently.\ + Commenting asking for status updates does not bump issue priority in any way and just serves to spam everyone subscribed to the issue. + name: Bump for Updates From 33a560af2ddcc3ea05a3613c0d39e790077b40b7 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sat, 10 Sep 2022 09:46:32 +1000 Subject: [PATCH 4/7] Less passive aggressive --- .github/replies.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/replies.yml b/.github/replies.yml index 567130996ba2..9bf9f05b594d 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -1,7 +1,6 @@ replies: - body: | - Maury meme: You checked 'I have searched for related issues'. A cursory issue search related issues determined that was a lie.\ - Thanks for posting, but this is a duplicate of #. Next time, please use the search 🙂. + Thanks for posting! This is a duplicate of #. Before filing an issue, please [use our issue search](https://github.com/typescript-eslint/typescript-eslint/issues) to check for open and closed issues that already address what you're looking for. name: Clearly Duplicate Issue - body: | With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.\ From 2fff7b7bccade8729280588967cace5975e5c084 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sat, 10 Sep 2022 10:02:45 +1000 Subject: [PATCH 5/7] Fill --- .github/replies.yml | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/.github/replies.yml b/.github/replies.yml index 9bf9f05b594d..0cc001522791 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -2,6 +2,24 @@ replies: - body: | Thanks for posting! This is a duplicate of #. Before filing an issue, please [use our issue search](https://github.com/typescript-eslint/typescript-eslint/issues) to check for open and closed issues that already address what you're looking for. name: Clearly Duplicate Issue + - body: | + Thanks for the issue! + \ + This is an extension rule. That means we take the base rule and extend it to support TS syntax or features. + \ + We don't break from the base rule to add new features unless they are specifically related to TS. + \ + In this instance - this request is not related to TS, thus we shall not implement it. If you'd like to see it, feel free to raise a request with the ESLint team. + \ + name: Extension Rule - Reject Due to Enhancement + - body: | + The fix has been merged to main, and will be released Monday, as per our [release schedule](https://github.com/typescript-eslint/typescript-eslint#versioning) + \ + If you need it sooner, please try the `canary` tag on NPM. + name: Fix has been merged + - body: | + + name: - body: | With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.\ \ @@ -11,4 +29,24 @@ replies: \ If not - please just subscribe to the issue and wait patiently.\ Commenting asking for status updates does not bump issue priority in any way and just serves to spam everyone subscribed to the issue. - name: Bump for Updates + name: Progress - Blunt + - body: | + We are a community run project. The **volunteer** maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues *will not progress* unless a member of the community steps up and **champions** it. + \ + If this issue is important to you - consider being that champion. + If not - please use the subscribe function and wait patiently for someone else to implement. + name: Progress - Nice + - body: | + As per [our contributing guidelines](https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#addressing-feedback-and-beyond) this PR is in the queue of PRs to reviewed, and will be reviewed when we are able. + \ + This project is run by volunteer maintainers, so it might be a bit before we can find the time to get to it. + name: Review Queue + - body: | + We ***STRONGLY*** recommend you use automatic code formatters like [prettier](https://www.npmjs.com/package/prettier). + \ + Stylistic lint rules take a lot of effort to write, require ongoing maintenance to add more configuration as people want to fit their preferences, and are a large burden to maintain as new syntax is added. + The configurability also leads to huge fanout [making tests huge, and awful to maintain](https://github.com/typescript-eslint/typescript-eslint/blob/b814e635c1f34139c89e0176727480935dd45cac/packages/eslint-plugin/tests/rules/type-annotation-spacing.test.ts). + \ + It's for these reasons that [eslint has frozen all stylistic lint rule options, and will not accept any new ones](https://eslint.org/blog/2020/05/changes-to-rules-policies). + See also our [What About Formatting?](https://typescript-eslint.io/docs/linting/troubleshooting/formatting) docs. + name: Use Prettier From ed5ebdd6bdeb7262a348b5728f6425174db0661d Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sun, 11 Sep 2022 13:30:40 -1000 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: Joshua Chen --- .github/replies.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/replies.yml b/.github/replies.yml index 0cc001522791..a20529df9be0 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -9,7 +9,7 @@ replies: \ We don't break from the base rule to add new features unless they are specifically related to TS. \ - In this instance - this request is not related to TS, thus we shall not implement it. If you'd like to see it, feel free to raise a request with the ESLint team. + In this instance — this request is not related to TS, thus we shall not implement it. If you'd like to see it, feel free to raise a request with the ESLint team. \ name: Extension Rule - Reject Due to Enhancement - body: | @@ -21,20 +21,20 @@ replies: name: - body: | - With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.\ + With any issue opened in this project — it either has visible progress in the form of an attached PR, or it has no progress.\ \ - We are a community run project. The volunteer maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues will not progress unless a member of the community steps up and champions it.\ + We are a community-run project. The volunteer maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues will not progress unless a member of the community steps up and champions it.\ \ - If this issue is important to you - consider being that champion.\ + If this issue is important to you — consider being that champion.\ \ - If not - please just subscribe to the issue and wait patiently.\ + If not — please just subscribe to the issue and wait patiently.\ Commenting asking for status updates does not bump issue priority in any way and just serves to spam everyone subscribed to the issue. name: Progress - Blunt - body: | We are a community run project. The **volunteer** maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues *will not progress* unless a member of the community steps up and **champions** it. \ - If this issue is important to you - consider being that champion. - If not - please use the subscribe function and wait patiently for someone else to implement. + If this issue is important to you — consider being that champion. + If not — please use the subscribe function and wait patiently for someone else to implement this. name: Progress - Nice - body: | As per [our contributing guidelines](https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#addressing-feedback-and-beyond) this PR is in the queue of PRs to reviewed, and will be reviewed when we are able. From ffdf798ebb1d990f0e29d51b39727e6bb86d3d6f Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sun, 11 Sep 2022 13:31:20 -1000 Subject: [PATCH 7/7] Title Case --- .github/replies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/replies.yml b/.github/replies.yml index a20529df9be0..299aa0441d3b 100644 --- a/.github/replies.yml +++ b/.github/replies.yml @@ -16,7 +16,7 @@ replies: The fix has been merged to main, and will be released Monday, as per our [release schedule](https://github.com/typescript-eslint/typescript-eslint#versioning) \ If you need it sooner, please try the `canary` tag on NPM. - name: Fix has been merged + name: Fix Has Been Merged - body: | name: