Skip to content

feat: update to TypeScript 4.9 #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 17, 2022
Merged

feat: update to TypeScript 4.9 #5716

merged 9 commits into from
Nov 17, 2022

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Oct 2, 2022 •
edited
Loading

We need to wait that RC version is released

PR Checklist

Overview

  • Install typescript@4.9.1-beta
  • Update the patch file for 4.9.1-beta
  • Run generate:lib

@nx-cloud
Copy link

nx-cloud bot commented Oct 2, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35809e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 2, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 35809e3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63629f3d2319200008b79176
😎 Deploy Preview https://deploy-preview-5716--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sosukesuzuki
sosukesuzuki commented Oct 2, 2022
View reviewed changes
package.json Outdated
"typescript": "~4.8.3",
"@types/node": "^17.0.31",
"typescript": "~4.9.1-beta",
"@types/node": "^18.7.23",

This comment was marked as resolved.

Sign in to view

@codecov
Copy link

codecov bot commented Oct 2, 2022 •
edited
Loading

Codecov Report

Merging #5716 (35809e3) into main (f11183c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5716   +/-   ##
=======================================
  Coverage   91.29%   91.30%           
=======================================
  Files         365      366    +1     
  Lines       12251    12255    +4     
  Branches     3577     3577           
=======================================
+ Hits        11185    11189    +4     
  Misses        758      758           
  Partials      308      308
Flag Coverage Δ
unittest 91.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2019.intl.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2019.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/index.ts 100.00% <100.00%> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts 95.96% <100.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <100.00%> (ø)

@sosukesuzuki sosukesuzuki mentioned this pull request Oct 2, 2022
Merged
3 tasks
@sosukesuzuki sosukesuzuki changed the title feat: Update to TypeScript 4.9 feat: update to TypeScript 4.9 Oct 2, 2022
@kasperpeulen kasperpeulen mentioned this pull request Oct 27, 2022
Closed
@kasperpeulen
Copy link

We need to wait that RC version is released

It has landed https://devblogs.microsoft.com/typescript/announcing-typescript-4-9-rc/ 🎉

@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 2, 2022 17:26
@sosukesuzuki
Copy link
Contributor Author

@bradzacher @JoshuaKGoldberg This PR is ready for review!

This was referenced Nov 4, 2022
Merged
Merged
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks!

I'm not 100% familiar with how these are generated so I'll defer to @bradzacher

@ngregory-rbi
Copy link

Given the final version of 4.9 is to release today, should we expect this to be merged and released anytime soon?

@kasperpeulen
Copy link

It would be great if we can test this already in a canary version.

@ngregory-rbi
Copy link

It would be great if we can test this already in a canary version.

Not sure which would be a canary, but there the 4.9.1-beta and the 4.9.2-rc.

@takurinton takurinton mentioned this pull request Nov 16, 2022
Closed
@bradzacher
Copy link
Member

Please follow along at the issue #5688 for status of support for TS4.9.
This PR is just about locally upgrading our package.

@shirotech

This comment was marked as spam.

Sign in to view
@bradzacher bradzacher merged commit 4d744ea into typescript-eslint:main Nov 17, 2022
@obulat obulat mentioned this pull request Nov 21, 2022
Merged
7 tasks
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Nov 23, 2022
@sosukesuzuki
feat: update to TypeScript 4.9 (typescript-eslint#5716)
aed2ecd 
* feat: update typescript to 4.9.1

* fix: add patch file for 4.9.1-beta

* feat(typescript-estree): update version range

* feat: run `generate-lib` script

* chore: update patch for typescript

* fix: run `lint-fix`

* feat: update to typescript 4.9.2-rc

* chore: run patch-package

* chore: update `@types/node`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sosukesuzuki @kasperpeulen @ngregory-rbi @bradzacher @shirotech @JoshuaKGoldberg @ArnaudBarre