Skip to content

fix(eslint-plugin): [keyword-spacing] prevent crash on no options #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix(eslint-plugin): [keyword-spacing] prevent crash on no options #6073

merged 1 commit into from
Nov 24, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Sources the after option from the second parameter to create instead of context.options. Turns out the latter is the raw user-provided options before defaultOptions are applied.

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e7ade5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 23, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6e7ade5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637e3f71ccf1f50008d17c2a
😎 Deploy Preview https://deploy-preview-6073--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 23, 2022 15:42
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #6073 (6e7ade5) into main (90d2ce0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6073   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         366      366           
  Lines       12353    12353           
  Branches     3612     3612           
=======================================
  Hits        11276    11276           
  Misses        768      768           
  Partials      309      309
Flag Coverage Δ
unittest 91.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/keyword-spacing.ts 100.00% <100.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team November 23, 2022 19:44
@bradzacher bradzacher added the bug Something isn't working label Nov 24, 2022
bradzacher
bradzacher approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elon_test_in_production

@bradzacher bradzacher merged commit 1f19998 into main Nov 24, 2022
@bradzacher bradzacher deleted the keyword-spacing-options branch November 24, 2022 00:20
@bradzacher bradzacher restored the keyword-spacing-options branch November 24, 2022 00:23
@bradzacher bradzacher deleted the keyword-spacing-options branch November 24, 2022 00:23
@bradzacher bradzacher restored the keyword-spacing-options branch November 24, 2022 00:25
@bradzacher bradzacher deleted the keyword-spacing-options branch November 24, 2022 00:25
@bradzacher bradzacher mentioned this pull request Nov 24, 2022
Merged
3 tasks
@rostislav-simonik rostislav-simonik mentioned this pull request Dec 1, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@omril1 omril1 omril1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: @typescript-eslint/keyword-spacing crashes
3 participants
@JoshuaKGoldberg @bradzacher @omril1