Skip to content

chore(website): fix base rule source links for extended rules #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 2, 2023

PR Checklist

Overview

If meta.docs.extendsBaseRule is true, then we should just go with file.stem.

Corrects the link to be the right md source path. Also moves the link to be underneath the new Resources section while I'm in the area. Feels like that makes more sense.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 369a01a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 2, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 369a01a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63b30c17ac594a0008532489
😎 Deploy Preview https://deploy-preview-6294--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(website): fix base rule source links forextended rules chore(website): fix base rule source links for extended rules Jan 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 2, 2023 17:04
@JoshuaKGoldberg JoshuaKGoldberg merged commit 073bf6c into typescript-eslint:main Jan 8, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-extends-base-rule-link branch January 8, 2023 18:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: bad links to base rules
2 participants