From 3086a5b0d984a1ed0f3c933cbd2cf0adf766f822 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sun, 19 Feb 2023 00:37:52 -0500 Subject: [PATCH 1/2] docs: mention re-requesting PR reviews --- docs/contributing/Pull_Requests.mdx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index c5af830718ce..39f25781299b 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -74,4 +74,7 @@ We generally review PRs oldest to newest, unless we consider a newer PR higher p Once we have reviewed your PR, we will provide any feedback that needs addressing. If you feel a requested change is wrong, don't be afraid to discuss with us in the comments. -Once the feedback is addressed, and the PR is reviewed, we'll ensure the branch is up to date with `main`, and merge it for you. + +Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed. + +Once the feedback is addressed, and the PR is approved, we'll ensure the branch is up to date with `main`, and merge it for you. From f8e501cea56815061c09c8e479bd4f23fc166e7c Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 21 Feb 2023 23:44:33 -0500 Subject: [PATCH 2/2] Mention comment threads --- docs/contributing/Pull_Requests.mdx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index 39f25781299b..36059661b4b1 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -75,6 +75,9 @@ We generally review PRs oldest to newest, unless we consider a newer PR higher p Once we have reviewed your PR, we will provide any feedback that needs addressing. If you feel a requested change is wrong, don't be afraid to discuss with us in the comments. +Please post comments as [line comments](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-line-comments-to-a-pull-request) when possible, so that they can be threaded. +You can [resolve conversations](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#resolving-conversations) on your own when you feel they're resolved - no need to comment explicitly and/or wait for a maintainer. + Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed. Once the feedback is addressed, and the PR is approved, we'll ensure the branch is up to date with `main`, and merge it for you.