Skip to content

feat(eslint-plugin): [no-unnecessary-cond] check logical assignments #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

feat(eslint-plugin): [no-unnecessary-cond] check logical assignments #6594

merged 1 commit into from
Mar 13, 2023

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Mar 10, 2023 •
edited
Loading

PR Checklist

Overview

Fixes #3553

@nx-cloud
Copy link

nx-cloud bot commented Mar 10, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2cda91f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 10, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2cda91f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/640aa21b33ce2500082b35c0
😎 Deploy Preview https://deploy-preview-6594--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #6594 (2cda91f) into main (006c86d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6594   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         376      376           
  Lines       12849    12853    +4     
  Branches     3783     3785    +2     
=======================================
+ Hits        11651    11655    +4     
  Misses        854      854           
  Partials      344      344
Flag Coverage Δ
unittest 90.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.37% <100.00%> (+0.03%) ⬆️

@bradzacher bradzacher added the enhancement New feature or request label Mar 13, 2023
bradzacher
bradzacher approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet - this looks good to me!

@bradzacher bradzacher added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit dbc203a into typescript-eslint:main Mar 13, 2023
@Josh-Cena Josh-Cena deleted the nuc-logical-assignment branch March 13, 2023 09:44
@ehoogeveen-medweb ehoogeveen-medweb mentioned this pull request Mar 14, 2023
Open
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-unnecessary-condition] False-negative with ??=
3 participants
@Josh-Cena @bradzacher @JoshuaKGoldberg