chore(website): update build script to use esbuild instead of rollup #6716

armano2 · 2023-03-21T01:36:55Z

PR Checklist

Addresses an existing open issue: #6656 comment
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

those changes have been extracted from #6656

migrate from rollup to esbuild
correct source map generation
reduce bundle size
simplify build

stats

bundling website-eslint: 220.45ms
netlify build time: ~ -2m (if we remove building all packages)
package size: ~ -250kb

source maps

this branch

v6

evanw/esbuild#819

typescript-eslint · 2023-03-21T01:36:57Z

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-03-21T01:37:05Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2d992dc`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6424f364c5947d00083985e1
😎 Deploy Preview	https://deploy-preview-6716--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bradzacher · 2023-03-21T01:43:16Z

ditto with #6656 - could we base this against the v6 branch?

nx-cloud · 2023-03-21T01:50:15Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d992dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

…rollup

…prove-build

codecov · 2023-03-21T11:31:01Z

Codecov Report

Merging #6716 (8c9a0cd) into v6 (6a307f0) will increase coverage by 2.21%.
The diff coverage is n/a.

❗ Current head 8c9a0cd differs from pull request most recent head 2d992dc. Consider uploading reports for the commit 2d992dc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6716      +/-   ##
==========================================
+ Coverage   85.15%   87.36%   +2.21%     
==========================================
  Files         383      373      -10     
  Lines       13026    12800     -226     
  Branches     3839     3793      -46     
==========================================
+ Hits        11092    11183      +91     
+ Misses       1572     1232     -340     
- Partials      362      385      +23

Flag	Coverage Δ
unittest	`87.36% <ø> (+2.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 163 files with indirect coverage changes

packages/website-eslint/src/index.js

packages/website-eslint/src/mock/path.js

…prove-build

…ur-own-risk

armano2 · 2023-03-25T05:19:30Z

@bradzacher i enabled type-checking for website-eslint and updated build to use source code instead of dist, I also removed most of no longer necessary use-at-your-own-risk as some of them where redundant and not really necessary

if you think that we should restore some of them let me know

bradzacher

remove the rollup config from renovate and we can land this

typescript-eslint/.github/renovate.json5

Lines 19 to 28 in 8ee0cbb

    
           // TODO - once we bump pass the major, we can remove these. Currently renovate is creating broken, immortal PRs 
        
           '@rollup/plugin-babel', 
        
           '@rollup/plugin-commonjs', 
        
           '@rollup/plugin-json', 
        
           '@rollup/plugin-node-resolve', 
        
           '@rollup/plugin-replace', 
        
           '@rollup/plugin-terser', 
        
           '@rollup/pluginutils', 
        
           'rollup-plugin-terser', 
        
           'rollup',

typescript-eslint/.github/renovate.json5

Lines 88 to 92 in 8ee0cbb

    
           { 
        
             matchPackagePrefixes: ['@rollup', 'rollup-'], 
        
             matchPackageNames: ['rollup'], 
        
             groupName: 'rollup', 
        
           },

armano2 added the website: playground label Mar 21, 2023

armano2 changed the base branch from main to v6 March 21, 2023 01:45

armano2 changed the base branch from v6 to main March 21, 2023 01:57

chore(website-eslint): update build script to use esbuild instead of …

01b9f00

…rollup

armano2 force-pushed the chore/website-eslint-improve-build branch from 741eb84 to 01b9f00 Compare March 21, 2023 02:13

armano2 changed the base branch from main to v6 March 21, 2023 02:13

armano2 changed the title ~~chore(website-eslint): update build script to use esbuild instead of rollup~~ chore(website): update build script to use esbuild instead of rollup Mar 21, 2023

armano2 added 2 commits March 21, 2023 11:15

Merge remote-tracking branch 'origin/v6' into chore/website-eslint-im…

ae2b1b1

…prove-build

fix: correct linting issues

539e391

bradzacher reviewed Mar 21, 2023

View reviewed changes

packages/website-eslint/src/index.js Outdated Show resolved Hide resolved

packages/website-eslint/src/mock/path.js Outdated Show resolved Hide resolved

armano2 added 2 commits March 24, 2023 07:35

Merge remote-tracking branch 'origin/v6' into chore/website-eslint-im…

730a92c

…prove-build

chore: build bundle from source code and remove unnecessary use-at-yo…

3a68591

…ur-own-risk

armano2 requested a review from bradzacher March 24, 2023 09:59

fix: correct displaying errors and warning

f6fb77f

armano2 requested a review from JoshuaKGoldberg March 24, 2023 10:58

armano2 added 2 commits March 25, 2023 04:36

fix: build code as iife to not pollute global scope

22b855b

fix: use banner & footer as amd wrapper

f1799d9

fix: add missing support for aliases

58d543d

armano2 mentioned this pull request Mar 26, 2023

chore(website): [playground] add support for extends, ts types and more #6656

Closed

3 tasks

armano2 added 2 commits March 29, 2023 18:09

Merge branch 'v6' into chore/website-eslint-improve-build

cf761c6

chore: restore missing comment

8c9a0cd

bradzacher approved these changes Mar 30, 2023

View reviewed changes

chore: remove rollup from renovate

2d992dc

armano2 merged commit 4eb0e3a into v6 Mar 30, 2023

armano2 deleted the chore/website-eslint-improve-build branch March 30, 2023 02:45

github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(website): update build script to use esbuild instead of rollup #6716

chore(website): update build script to use esbuild instead of rollup #6716

armano2 commented Mar 21, 2023 •

edited

Loading

typescript-eslint bot commented Mar 21, 2023

netlify bot commented Mar 21, 2023 •

edited

Loading

bradzacher commented Mar 21, 2023

nx-cloud bot commented Mar 21, 2023 •

edited

Loading

codecov bot commented Mar 21, 2023 •

edited

Loading

armano2 commented Mar 25, 2023

bradzacher left a comment

	// TODO - once we bump pass the major, we can remove these. Currently renovate is creating broken, immortal PRs
	'@rollup/plugin-babel',
	'@rollup/plugin-commonjs',
	'@rollup/plugin-json',
	'@rollup/plugin-node-resolve',
	'@rollup/plugin-replace',
	'@rollup/plugin-terser',
	'@rollup/pluginutils',
	'rollup-plugin-terser',
	'rollup',

	{
	matchPackagePrefixes: ['@rollup', 'rollup-'],
	matchPackageNames: ['rollup'],
	groupName: 'rollup',
	},

chore(website): update build script to use esbuild instead of rollup #6716

chore(website): update build script to use esbuild instead of rollup #6716

Conversation

armano2 commented Mar 21, 2023 • edited Loading

PR Checklist

Overview

stats

this branch

v6

typescript-eslint bot commented Mar 21, 2023

netlify bot commented Mar 21, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

bradzacher commented Mar 21, 2023

nx-cloud bot commented Mar 21, 2023 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Mar 21, 2023 • edited Loading

Codecov Report

armano2 commented Mar 25, 2023

bradzacher left a comment

Choose a reason for hiding this comment

armano2 commented Mar 21, 2023 •

edited

Loading

netlify bot commented Mar 21, 2023 •

edited

Loading

nx-cloud bot commented Mar 21, 2023 •

edited

Loading

codecov bot commented Mar 21, 2023 •

edited

Loading