Skip to content

docs: reorder Details & Next Steps in Getting Started #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

docs: reorder Details & Next Steps in Getting Started #6920

merged 2 commits into from
Apr 25, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Applies the suggested reorder, and also mentions root: true (since it wasn't before).

cc @Jutanium - would love your eyes on this too if you have time! 😄

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 16, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e15aa71
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/643ea027e3e40a000862ebe8
😎 Deploy Preview https://deploy-preview-6920--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Apr 16, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e15aa71. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Apr 17, 2023
Josh-Cena
Josh-Cena reviewed Apr 17, 2023
View reviewed changes
@JoshuaKGoldberg @Josh-Cena
Update docs/Getting_Started.mdx
e15aa71 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #6920 (e15aa71) into main (ff65235) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6920   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         386      386           
  Lines       13192    13192           
  Branches     3867     3867           
=======================================
  Hits        11526    11526           
  Misses       1300     1300           
  Partials      366      366
Flag Coverage Δ
unittest 87.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Josh-Cena
Josh-Cena approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoshuaKGoldberg JoshuaKGoldberg merged commit b6dd303 into typescript-eslint:main Apr 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the getting-started-reorder branch April 25, 2023 22:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Consider reordering Details & Next Steps in Getting Started
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena