From dbf2b78376912bd51d319dfcf345e2207e47efe1 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 29 Apr 2023 15:05:21 -0700 Subject: [PATCH 1/3] docs: add a section suggesting gifs for pr reviews --- docs/maintenance/Pull_Requests.mdx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/maintenance/Pull_Requests.mdx b/docs/maintenance/Pull_Requests.mdx index 37c6b40256cb..971a231b0abd 100644 --- a/docs/maintenance/Pull_Requests.mdx +++ b/docs/maintenance/Pull_Requests.mdx @@ -32,3 +32,8 @@ Our flow for PRs that have been waiting for >=1 month is: 2. Add the `stale` label to the PR 3. Wait 2 weeks 4. If they still haven't responded, close the PR with a message like the _Pruning Stale PR_ template + + +## Suggestions + +Add some fun to PR reviews with GIFs. It's a great way to create a fun and welcoming environment while still maintaining a professional and productive one. The benefits of using GIFs in PR reviews are that it adds a touch of humor and lightheartedness to the process, builds camaraderie and team spirit, and can help break the ice by making users feel welcomed. Please remember to use appropriate and respectful GIFs and use them sparingly; GIFs should enhance the conversation, not detract from it. Check out [GIFs for Github here](https://chrome.google.com/webstore/detail/gifs-for-github/dkgjnpbipbdaoaadbdhpiokaemhlphep) or [for Firefox here](https://addons.mozilla.org/en-US/firefox/addon/gifs-for-github/). Have some fun with it and happy GIF-ing. From f3047ed5daa054ca318ce3c28f500790c1e6c612 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 29 Apr 2023 18:53:23 -0700 Subject: [PATCH 2/3] fix extra line --- docs/maintenance/Pull_Requests.mdx | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/maintenance/Pull_Requests.mdx b/docs/maintenance/Pull_Requests.mdx index 971a231b0abd..f8319e89dff2 100644 --- a/docs/maintenance/Pull_Requests.mdx +++ b/docs/maintenance/Pull_Requests.mdx @@ -33,7 +33,6 @@ Our flow for PRs that have been waiting for >=1 month is: 3. Wait 2 weeks 4. If they still haven't responded, close the PR with a message like the _Pruning Stale PR_ template - ## Suggestions Add some fun to PR reviews with GIFs. It's a great way to create a fun and welcoming environment while still maintaining a professional and productive one. The benefits of using GIFs in PR reviews are that it adds a touch of humor and lightheartedness to the process, builds camaraderie and team spirit, and can help break the ice by making users feel welcomed. Please remember to use appropriate and respectful GIFs and use them sparingly; GIFs should enhance the conversation, not detract from it. Check out [GIFs for Github here](https://chrome.google.com/webstore/detail/gifs-for-github/dkgjnpbipbdaoaadbdhpiokaemhlphep) or [for Firefox here](https://addons.mozilla.org/en-US/firefox/addon/gifs-for-github/). Have some fun with it and happy GIF-ing. From 3f4f3e4bad1a98a7aeeda08dac1dd99cc2797d89 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sun, 28 May 2023 09:08:47 -0700 Subject: [PATCH 3/3] remove duplication and keep to one sentence per line MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Josh Goldberg ✨ --- docs/maintenance/Pull_Requests.mdx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/maintenance/Pull_Requests.mdx b/docs/maintenance/Pull_Requests.mdx index f8319e89dff2..02f00ac952d0 100644 --- a/docs/maintenance/Pull_Requests.mdx +++ b/docs/maintenance/Pull_Requests.mdx @@ -35,4 +35,8 @@ Our flow for PRs that have been waiting for >=1 month is: ## Suggestions -Add some fun to PR reviews with GIFs. It's a great way to create a fun and welcoming environment while still maintaining a professional and productive one. The benefits of using GIFs in PR reviews are that it adds a touch of humor and lightheartedness to the process, builds camaraderie and team spirit, and can help break the ice by making users feel welcomed. Please remember to use appropriate and respectful GIFs and use them sparingly; GIFs should enhance the conversation, not detract from it. Check out [GIFs for Github here](https://chrome.google.com/webstore/detail/gifs-for-github/dkgjnpbipbdaoaadbdhpiokaemhlphep) or [for Firefox here](https://addons.mozilla.org/en-US/firefox/addon/gifs-for-github/). Have some fun with it and happy GIF-ing. +Consider adding fun to PR reviews with GIFs. +The benefits of using GIFs in PR reviews are that it adds a touch of humor and lightheartedness to the process, builds camaraderie and team spirit, and can help break the ice by making users feel welcomed. +Please remember to use appropriate and respectful GIFs and use them sparingly; GIFs should enhance the conversation, not detract from it. + +> We like to use the _GIFs for Github_ extension: available as [GIFs for GitHub (Chrome)](https://chrome.google.com/webstore/detail/gifs-for-github/dkgjnpbipbdaoaadbdhpiokaemhlphep) and [GIFs for GitHub (Firefox)](https://addons.mozilla.org/en-US/firefox/addon/gifs-for-github). ✨