Skip to content

feat(utils): add ESLint CodePath selector types #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 13, 2023
Merged

feat(utils): add ESLint CodePath selector types #7551

merged 15 commits into from
Nov 13, 2023

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Aug 28, 2023 •
edited
Loading

PR Checklist

Overview

Adds exported CodePath interfaces and un-commented the onCodePathStart and onCodePathEnd methods, which makes things slightly less painful for people who have custom rules that use this feature.

Based on: #6679

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0b1de44
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65523587cb214c00088c1bd0
😎 Deploy Preview https://deploy-preview-7551--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aa3f504. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx run-many --target=lint --parallel
✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@Zamiell
Copy link
Contributor Author

Zamiell commented Aug 29, 2023 •
edited
Loading

CI is drunk, the codebase builds just fine for me locally (after my latest commit). Can a maintainer reset the CI cache or something?

@Zamiell
Copy link
Contributor Author

Zamiell commented Aug 29, 2023

Oh, actually on second thought, it just looks like it is failing a spell check on code that is unrelated to my PR, so a maintainer should fix that.

bradzacher
bradzacher requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far!

@bradzacher bradzacher added enhancement New feature or request awaiting response Issues waiting for a reply from the OP or another party labels Sep 8, 2023
@bradzacher bradzacher changed the title feat: add CodePath interfaces feat(utils): add ESLint CodePath selector types Sep 8, 2023
@Zamiell Zamiell requested a review from bradzacher September 16, 2023 02:41
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 16, 2023
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2023
@Zamiell
Copy link
Contributor Author

Zamiell commented Nov 10, 2023

ok, i addressed the feedback and merged with the main branch

@bradzacher bradzacher added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Nov 12, 2023
@bradzacher
Copy link
Member

For future reference - I'd avoid working from a repo in an org account and instead work from a fork on your personal account. We maintainers can't modify your PR at all - even the standard "update branch" button which auto-merges main doesn't work. This can make it difficult to manage your OSS contributions because we have to ping you and wait for your action even for trivial things like merging main - which we sometimes need to do if main was broken (eg in this case the CI was broken!).

Please merge main so we can kick off the CI again with the latest deps then we can merge this.

@Zamiell
Copy link
Contributor Author

Zamiell commented Nov 13, 2023

Please merge main

done!

@JoshuaKGoldberg
Copy link
Member

...aaaand lint is broken on main. Sorry 😄 we can just take this as-is and fix linting separately. #7913

@JoshuaKGoldberg JoshuaKGoldberg merged commit 99a026f into typescript-eslint:main Nov 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
@Zamiell Zamiell deleted the interfaces branch December 2, 2023 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Support CodePath rule listener methods
4 participants
@Zamiell @bradzacher @JoshuaKGoldberg @armano2