From bc9f74f81de23ad103bc96be1d70e919710d1298 Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Wed, 27 Dec 2023 08:43:43 +0000
Subject: [PATCH 1/9] test(eslint-plugin): assert that `ts`/`tsx` code blocks
 in docs are syntactically valid

---
 .../docs/rules/consistent-type-assertions.md  | 66 ++++++++++++++-----
 .../rules/explicit-function-return-type.md    |  4 --
 .../rules/explicit-member-accessibility.md    | 16 ++---
 .../docs/rules/member-ordering.md             |  2 -
 .../docs/rules/no-empty-function.md           |  3 -
 .../eslint-plugin/docs/rules/no-type-alias.md | 32 +++++----
 .../rules/no-unnecessary-type-arguments.md    |  4 +-
 .../rules/no-unnecessary-type-constraint.md   |  2 +-
 .../docs/rules/prefer-enum-initializers.md    |  2 +-
 .../docs/rules/space-before-blocks.md         | 10 +--
 packages/eslint-plugin/docs/rules/typedef.md  |  6 +-
 packages/eslint-plugin/tests/docs.test.ts     | 29 ++++++++
 12 files changed, 123 insertions(+), 53 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
index b453e7201aa6..debfd0bbc152 100644
--- a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
+++ b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
@@ -54,22 +54,34 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'neve
 #### ❌ Incorrect
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "never" }'
-const x = { ... } as T;
+const x = {
+  // ...
+} as T;
 
 function foo() {
-  return { ... } as T;
+  return {
+    // ...
+  } as T;
 }
 ```
 
 #### ✅ Correct
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "never" }'
-const x: T = { ... };
-const y = { ... } as any;
-const z = { ... } as unknown;
+const x: T = {
+  // ...
+};
+const y = {
+  // ...
+} as any;
+const z = {
+  // ...
+} as unknown;
 
 function foo(): T {
-  return { ... };
+  return {
+    // ...
+  };
 }
 ```
 
@@ -82,23 +94,47 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allo
 #### ❌ Incorrect
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }'
-const x = { ... } as T;
+const x = {
+  // ...
+} as T;
 
 function foo() {
-  return { ... } as T;
+  return {
+    // ...
+  } as T;
 }
 ```
 
 #### ✅ Correct
 
 ```tsx option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }'
-const x: T = { ... };
-const y = { ... } as any;
-const z = { ... } as unknown;
-foo({ ... } as T);
-new Clazz({ ... } as T);
-function foo() { throw { bar: 5 } as Foo }
-const foo = <Foo props={{ ... } as Bar}/>;
+const x: T = {
+  // ...
+};
+const y = {
+  // ...
+} as any;
+const z = {
+  // ...
+} as unknown;
+foo({
+  // ...
+} as T);
+new Clazz({
+  // ...
+} as T);
+function foo() {
+  throw { bar: 5 } as Foo;
+}
+const foo = (
+  <Foo
+    props={
+      {
+        // ...
+      } as Bar
+    }
+  />
+);
 ```
 
 <!--/tabs-->
diff --git a/packages/eslint-plugin/docs/rules/explicit-function-return-type.md b/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
index ad6b5598e557..ca4d019df906 100644
--- a/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
+++ b/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
@@ -172,10 +172,6 @@ functionWithObjectArg({
     return 1;
   },
 });
-
-const Comp: FC = () => {
-  return <button onClick={() => {}} />;
-};
 ```
 
 ### `allowHigherOrderFunctions`
diff --git a/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md b/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md
index 0e375c96937b..cf124524deb0 100644
--- a/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md
+++ b/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md
@@ -48,15 +48,15 @@ If you are working on a codebase within which you lint non-TypeScript code (i.e.
 
 This rule in its default state requires no configuration and will enforce that every class member has an accessibility modifier. If you would like to allow for some implicit public members then you have the following options:
 
-```ts
+```jsonc
 {
-  accessibility: 'explicit',
-  overrides: {
-    accessors: 'explicit',
-    constructors: 'no-public',
-    methods: 'explicit',
-    properties: 'off',
-    parameterProperties: 'explicit'
+  "accessibility: "explicit",
+  "overrides": {
+    "accessors": "explicit",
+    "constructors": "no-public",
+    "methods": "explicit",
+    "properties": "off",
+    "parameterProperties": "explicit"
   }
 }
 ```
diff --git a/packages/eslint-plugin/docs/rules/member-ordering.md b/packages/eslint-plugin/docs/rules/member-ordering.md
index 711d590728c1..aefb1b3e0897 100644
--- a/packages/eslint-plugin/docs/rules/member-ordering.md
+++ b/packages/eslint-plugin/docs/rules/member-ordering.md
@@ -920,7 +920,6 @@ It ignores any member group types completely by specifying `"never"` for `member
 
 ```ts option='{ "default": { "memberTypes": "never", "order": "alphabetically" } }'
 interface Foo {
-  static c = 0;
   b(): void;
   a: boolean;
 
@@ -936,7 +935,6 @@ interface Foo {
 interface Foo {
   a: boolean;
   b(): void;
-  static c = 0;
 
   [a: string]: number; // Order doesn't matter (no sortable identifier)
   new (): Bar; // Order doesn't matter (no sortable identifier)
diff --git a/packages/eslint-plugin/docs/rules/no-empty-function.md b/packages/eslint-plugin/docs/rules/no-empty-function.md
index 6275a1de7f77..30e8109b05b6 100644
--- a/packages/eslint-plugin/docs/rules/no-empty-function.md
+++ b/packages/eslint-plugin/docs/rules/no-empty-function.md
@@ -60,9 +60,6 @@ class Foo {
 Examples of correct code for the `{ "allow": ["decoratedFunctions"] }` option:
 
 ```ts option='{ "allow": ["decoratedFunctions"] }' showPlaygroundButton
-@decorator()
-function foo() {}
-
 class Foo {
   @decorator()
   foo() {}
diff --git a/packages/eslint-plugin/docs/rules/no-type-alias.md b/packages/eslint-plugin/docs/rules/no-type-alias.md
index 527903e6a5cb..e34b23548bb9 100644
--- a/packages/eslint-plugin/docs/rules/no-type-alias.md
+++ b/packages/eslint-plugin/docs/rules/no-type-alias.md
@@ -27,15 +27,23 @@ In TypeScript, type aliases serve three purposes:
 ```ts
 // this...
 type Person = {
-    firstName: string,
-    lastName: string,
-    age: number
+  firstName: string;
+  lastName: string;
+  age: number;
 };
 
-function addPerson(person : Person) { ... }
+function addPerson(person: Person) {
+  // ...
+}
 
 // is easier to read than this...
-function addPerson(person : { firstName: string, lastName: string, age: number}) { ... }
+function addPerson(person: {
+  firstName: string;
+  lastName: string;
+  age: number;
+}) {
+  // ...
+}
 ```
 
 - Act sort of like an interface, providing a set of methods and properties that must exist
@@ -43,16 +51,18 @@ function addPerson(person : { firstName: string, lastName: string, age: number})
 
 ```ts
 type Person = {
-    firstName: string,
-    lastName: string,
-    age: number,
-    walk: () => void,
-    talk: () => void
+  firstName: string;
+  lastName: string;
+  age: number;
+  walk: () => void;
+  talk: () => void;
 };
 
 // you know person will have 3 properties and 2 methods,
 // because the structure has already been defined.
-var person : Person = { ... }
+var person: Person = {
+  // ...
+};
 
 // so we can be sure that this will work
 person.walk();
diff --git a/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md b/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md
index aa75e0359f4f..c13586740883 100644
--- a/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md
+++ b/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md
@@ -10,7 +10,9 @@ Type parameters in TypeScript may specify a default value.
 For example:
 
 ```ts
-function f<T = number>(...) {...}
+function f<T = number>(/* ... */) {
+  // ...
+}
 ```
 
 It is redundant to provide an explicit type parameter equal to that default: e.g. calling `f<number>(...)`.
diff --git a/packages/eslint-plugin/docs/rules/no-unnecessary-type-constraint.md b/packages/eslint-plugin/docs/rules/no-unnecessary-type-constraint.md
index 5fd0e70d6532..e5dedc0ee141 100644
--- a/packages/eslint-plugin/docs/rules/no-unnecessary-type-constraint.md
+++ b/packages/eslint-plugin/docs/rules/no-unnecessary-type-constraint.md
@@ -42,7 +42,7 @@ interface Foo<T> {}
 type Bar<T> = {};
 
 class Baz<T> {
-  qux<U> { }
+  qux<U>() {}
 }
 
 const Quux = <T>() => {};
diff --git a/packages/eslint-plugin/docs/rules/prefer-enum-initializers.md b/packages/eslint-plugin/docs/rules/prefer-enum-initializers.md
index 1c4204b665c0..3d9b9b2e801c 100644
--- a/packages/eslint-plugin/docs/rules/prefer-enum-initializers.md
+++ b/packages/eslint-plugin/docs/rules/prefer-enum-initializers.md
@@ -32,7 +32,7 @@ enum Direction {
 
 enum Color {
   Red,
-  Green = 'Green'
+  Green = 'Green',
   Blue = 'Blue',
 }
 ```
diff --git a/packages/eslint-plugin/docs/rules/space-before-blocks.md b/packages/eslint-plugin/docs/rules/space-before-blocks.md
index 60a24043d300..844962d50254 100644
--- a/packages/eslint-plugin/docs/rules/space-before-blocks.md
+++ b/packages/eslint-plugin/docs/rules/space-before-blocks.md
@@ -14,11 +14,12 @@ It adds support for interfaces and enums.
 ### ❌ Incorrect
 
 ```ts
-enum Breakpoint{
-  Large, Medium;
+enum Breakpoint {
+  Large,
+  Medium,
 }
 
-interface State{
+interface State {
   currentBreakpoint: Breakpoint;
 }
 ```
@@ -27,7 +28,8 @@ interface State{
 
 ```ts
 enum Breakpoint {
-  Large, Medium;
+  Large,
+  Medium,
 }
 
 interface State {
diff --git a/packages/eslint-plugin/docs/rules/typedef.md b/packages/eslint-plugin/docs/rules/typedef.md
index b6e0d9714d61..59c1b440523f 100644
--- a/packages/eslint-plugin/docs/rules/typedef.md
+++ b/packages/eslint-plugin/docs/rules/typedef.md
@@ -298,13 +298,13 @@ const text = 'text';
 
 ```ts option='{ "variableDeclaration": true, "variableDeclarationIgnoreFunction": true }'
 const a = (): void => {};
-const b = function (): void => {};
+const b = function (): void {};
 const c: () => void = (): void => {};
 
 class Foo {
   a = (): void => {};
-  b = function (): void => {};
-  c = () => void = (): void => {};
+  b = function (): void {};
+  c: () => void = (): void => {};
 }
 ```
 
diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
index b10ce6d78242..ce5aae6d9abf 100644
--- a/packages/eslint-plugin/tests/docs.test.ts
+++ b/packages/eslint-plugin/tests/docs.test.ts
@@ -1,3 +1,4 @@
+import { parseForESLint } from '@typescript-eslint/parser';
 import fs from 'fs';
 import { marked } from 'marked';
 import path from 'path';
@@ -180,6 +181,34 @@ describe('Validating rule docs', () => {
           }
         });
       }
+
+      test('must include only valid code samples', () => {
+        const { tokens } = parseMarkdownFile(filePath);
+
+        for (const token of tokens) {
+          if (token.type !== 'code') {
+            continue;
+          }
+
+          const lang = token.lang?.trim();
+          if (!lang?.startsWith('ts')) {
+            return;
+          }
+
+          try {
+            parseForESLint(token.text, {
+              ecmaFeatures: {
+                jsx: lang.startsWith('tsx'),
+              },
+              ecmaVersion: 'latest',
+              sourceType: 'module',
+              range: true,
+            });
+          } catch (e) {
+            throw new Error(`Parsing error:\n\n${token.text}`);
+          }
+        }
+      });
     });
   }
 });

From ef2b0b7748c155cda3192a4193d6573936d6f80b Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Wed, 27 Dec 2023 08:51:28 +0000
Subject: [PATCH 2/9] revert unintended changes in space-before-blocks.md

---
 packages/eslint-plugin/docs/rules/space-before-blocks.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/space-before-blocks.md b/packages/eslint-plugin/docs/rules/space-before-blocks.md
index 844962d50254..14497f7b62a7 100644
--- a/packages/eslint-plugin/docs/rules/space-before-blocks.md
+++ b/packages/eslint-plugin/docs/rules/space-before-blocks.md
@@ -13,13 +13,14 @@ It adds support for interfaces and enums.
 
 ### ❌ Incorrect
 
+<!-- prettier-ignore -->
 ```ts
-enum Breakpoint {
+enum Breakpoint{
   Large,
   Medium,
 }
 
-interface State {
+interface State{
   currentBreakpoint: Breakpoint;
 }
 ```

From 4cad96e9ab26720e4709f24d3d8e0fe52ee8b530 Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Wed, 27 Dec 2023 08:58:16 +0000
Subject: [PATCH 3/9] chore: shorten examples in consistent-type-assertions.md

---
 .../docs/rules/consistent-type-assertions.md  | 64 +++++--------------
 1 file changed, 15 insertions(+), 49 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
index debfd0bbc152..770b97f18a5d 100644
--- a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
+++ b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
@@ -54,34 +54,22 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'neve
 #### ❌ Incorrect
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "never" }'
-const x = {
-  // ...
-} as T;
+const x = { foo: 1 } as T;
 
 function foo() {
-  return {
-    // ...
-  } as T;
+  return { bar: 1 } as T;
 }
 ```
 
 #### ✅ Correct
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "never" }'
-const x: T = {
-  // ...
-};
-const y = {
-  // ...
-} as any;
-const z = {
-  // ...
-} as unknown;
+const x: T = { foo: 1 };
+const y = { foo: 1 } as any;
+const z = { foo: 1 } as unknown;
 
 function foo(): T {
-  return {
-    // ...
-  };
+  return { bar: 1 };
 }
 ```
 
@@ -94,47 +82,25 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allo
 #### ❌ Incorrect
 
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }'
-const x = {
-  // ...
-} as T;
+const x = { foo: 1 } as T;
 
 function foo() {
-  return {
-    // ...
-  } as T;
+  return { bar: 1 } as T;
 }
 ```
 
 #### ✅ Correct
 
 ```tsx option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }'
-const x: T = {
-  // ...
-};
-const y = {
-  // ...
-} as any;
-const z = {
-  // ...
-} as unknown;
-foo({
-  // ...
-} as T);
-new Clazz({
-  // ...
-} as T);
+const x: T = { foo: 1 };
+const y = { foo: 1 } as any;
+const z = { foo: 1 } as unknown;
+foo({ bar: 1 } as T);
+new Clazz({ foo: 1 } as T);
 function foo() {
-  throw { bar: 5 } as Foo;
+  throw { bar: 1 } as Foo;
 }
-const foo = (
-  <Foo
-    props={
-      {
-        // ...
-      } as Bar
-    }
-  />
-);
+const foo = <Foo props={{ foo: 1 } as Bar} />;
 ```
 
 <!--/tabs-->

From e3c374ae71a059d3dcad24b675844bbe18feac73 Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Wed, 27 Dec 2023 08:58:42 +0000
Subject: [PATCH 4/9] refactor: do not parse md file again

---
 packages/eslint-plugin/tests/docs.test.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
index ce5aae6d9abf..424a887bc325 100644
--- a/packages/eslint-plugin/tests/docs.test.ts
+++ b/packages/eslint-plugin/tests/docs.test.ts
@@ -183,8 +183,6 @@ describe('Validating rule docs', () => {
       }
 
       test('must include only valid code samples', () => {
-        const { tokens } = parseMarkdownFile(filePath);
-
         for (const token of tokens) {
           if (token.type !== 'code') {
             continue;

From 9b7a3f175414e943ad749d0877dee8bd1ef7e95d Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Mon, 8 Jan 2024 05:11:36 +0000
Subject: [PATCH 5/9] docs: more consistent examples for
 consistent-type-assertions

---
 .../docs/rules/consistent-type-assertions.md  | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
index 770b97f18a5d..7bd4412470e5 100644
--- a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
+++ b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
@@ -56,8 +56,8 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'neve
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "never" }'
 const x = { foo: 1 } as T;
 
-function foo() {
-  return { bar: 1 } as T;
+function bar() {
+  return { foo: 1 } as T;
 }
 ```
 
@@ -68,8 +68,8 @@ const x: T = { foo: 1 };
 const y = { foo: 1 } as any;
 const z = { foo: 1 } as unknown;
 
-function foo(): T {
-  return { bar: 1 };
+function bar(): T {
+  return { foo: 1 };
 }
 ```
 
@@ -84,8 +84,8 @@ Examples of code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allo
 ```ts option='{ "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }'
 const x = { foo: 1 } as T;
 
-function foo() {
-  return { bar: 1 } as T;
+function bar() {
+  return { foo: 1 } as T;
 }
 ```
 
@@ -95,12 +95,12 @@ function foo() {
 const x: T = { foo: 1 };
 const y = { foo: 1 } as any;
 const z = { foo: 1 } as unknown;
-foo({ bar: 1 } as T);
+bar({ foo: 1 } as T);
 new Clazz({ foo: 1 } as T);
-function foo() {
-  throw { bar: 1 } as Foo;
+function bar() {
+  throw { foo: 1 } as Foo;
 }
-const foo = <Foo props={{ foo: 1 } as Bar} />;
+const foo = <Foo props={{ bar: 1 } as Bar} />;
 ```
 
 <!--/tabs-->

From 7fe7309dbc4a0a98e3d458d5aeaded91e3588e0b Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Mon, 8 Jan 2024 05:16:29 +0000
Subject: [PATCH 6/9] docs: convert `js` code blocks to `ts`

---
 packages/eslint-plugin/docs/rules/ban-tslint-comment.md | 4 ++--
 packages/eslint-plugin/docs/rules/no-for-in-array.md    | 6 +++---
 packages/eslint-plugin/docs/rules/no-this-alias.md      | 4 ++--
 packages/eslint-plugin/docs/rules/prefer-for-of.md      | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/ban-tslint-comment.md b/packages/eslint-plugin/docs/rules/ban-tslint-comment.md
index eac42f6cdabf..c2529de6179f 100644
--- a/packages/eslint-plugin/docs/rules/ban-tslint-comment.md
+++ b/packages/eslint-plugin/docs/rules/ban-tslint-comment.md
@@ -16,7 +16,7 @@ Useful when migrating from TSLint to ESLint. Once TSLint has been removed, this
 
 ### ❌ Incorrect
 
-```js
+```ts
 /* tslint:disable */
 /* tslint:enable */
 /* tslint:disable:rule1 rule2 rule3... */
@@ -28,7 +28,7 @@ someCode(); // tslint:disable-line
 
 ### ✅ Correct
 
-```js
+```ts
 // This is a comment that just happens to mention tslint
 /* This is a multiline comment that just happens to mention tslint */
 someCode(); // This is a comment that just happens to mention tslint
diff --git a/packages/eslint-plugin/docs/rules/no-for-in-array.md b/packages/eslint-plugin/docs/rules/no-for-in-array.md
index 4fb481cf469c..4ba6003f7669 100644
--- a/packages/eslint-plugin/docs/rules/no-for-in-array.md
+++ b/packages/eslint-plugin/docs/rules/no-for-in-array.md
@@ -21,7 +21,7 @@ You may have confused for-in with for-of, which iterates over the elements of th
 
 ### ❌ Incorrect
 
-```js
+```ts
 declare const array: string[];
 
 for (const i in array) {
@@ -35,7 +35,7 @@ for (const i in array) {
 
 ### ✅ Correct
 
-```js
+```ts
 declare const array: string[];
 
 for (const value of array) {
@@ -48,7 +48,7 @@ for (let i = 0; i < array.length; i += 1) {
 
 array.forEach((value, i) => {
   console.log(i, value);
-})
+});
 
 for (const [i, value] of array.entries()) {
   console.log(i, value);
diff --git a/packages/eslint-plugin/docs/rules/no-this-alias.md b/packages/eslint-plugin/docs/rules/no-this-alias.md
index 6014e56c3237..2b1222923d3b 100644
--- a/packages/eslint-plugin/docs/rules/no-this-alias.md
+++ b/packages/eslint-plugin/docs/rules/no-this-alias.md
@@ -15,7 +15,7 @@ or not managing scope well.
 
 ### ❌ Incorrect
 
-```js
+```ts
 const self = this;
 
 setTimeout(function () {
@@ -25,7 +25,7 @@ setTimeout(function () {
 
 ### ✅ Correct
 
-```js
+```ts
 setTimeout(() => {
   this.doWork();
 });
diff --git a/packages/eslint-plugin/docs/rules/prefer-for-of.md b/packages/eslint-plugin/docs/rules/prefer-for-of.md
index 873d28bd7f0f..ceaeecce1e8a 100644
--- a/packages/eslint-plugin/docs/rules/prefer-for-of.md
+++ b/packages/eslint-plugin/docs/rules/prefer-for-of.md
@@ -18,7 +18,7 @@ This rule recommends a for-of loop when the loop index is only used to read from
 
 ### ❌ Incorrect
 
-```js
+```ts
 declare const array: string[];
 
 for (let i = 0; i < array.length; i++) {
@@ -28,7 +28,7 @@ for (let i = 0; i < array.length; i++) {
 
 ### ✅ Correct
 
-```js
+```ts
 declare const array: string[];
 
 for (const x of array) {

From 049d172d5f587406b6175755fd03f79404fcdb5a Mon Sep 17 00:00:00 2001
From: auvred <61150013+auvred@users.noreply.github.com>
Date: Mon, 8 Jan 2024 22:00:42 +0300
Subject: [PATCH 7/9] Update packages/eslint-plugin/tests/docs.test.ts
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
---
 packages/eslint-plugin/tests/docs.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
index 424a887bc325..23e4bd10ff0e 100644
--- a/packages/eslint-plugin/tests/docs.test.ts
+++ b/packages/eslint-plugin/tests/docs.test.ts
@@ -202,7 +202,7 @@ describe('Validating rule docs', () => {
               sourceType: 'module',
               range: true,
             });
-          } catch (e) {
+          } catch {
             throw new Error(`Parsing error:\n\n${token.text}`);
           }
         }

From 90e3409d2ec7f7a037ffa7d961b0dd1fc709bbd6 Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Sat, 13 Jan 2024 07:12:05 +0000
Subject: [PATCH 8/9] chore: use regex instead of startsWith

---
 packages/eslint-plugin/tests/docs.test.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
index 23e4bd10ff0e..9d99ca159103 100644
--- a/packages/eslint-plugin/tests/docs.test.ts
+++ b/packages/eslint-plugin/tests/docs.test.ts
@@ -189,14 +189,14 @@ describe('Validating rule docs', () => {
           }
 
           const lang = token.lang?.trim();
-          if (!lang?.startsWith('ts')) {
-            return;
+          if (!lang || !/^tsx?\b/i.test(lang)) {
+            continue;
           }
 
           try {
             parseForESLint(token.text, {
               ecmaFeatures: {
-                jsx: lang.startsWith('tsx'),
+                jsx: /^tsx\b/i.test(lang),
               },
               ecmaVersion: 'latest',
               sourceType: 'module',

From 960e64177ac52e7254ef9d5120d4ae48d232bf87 Mon Sep 17 00:00:00 2001
From: auvred <aauvred@gmail.com>
Date: Sat, 13 Jan 2024 07:12:35 +0000
Subject: [PATCH 9/9] chore: fix few codesamples

---
 .../docs/rules/explicit-function-return-type.md           | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/eslint-plugin/docs/rules/explicit-function-return-type.md b/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
index ca4d019df906..2d02e06bdf01 100644
--- a/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
+++ b/packages/eslint-plugin/docs/rules/explicit-function-return-type.md
@@ -143,7 +143,7 @@ type FuncType = () => string;
 
 let arrowFn: FuncType = () => 'test';
 
-let funcExpr: FuncType = function() {
+let funcExpr: FuncType = function () {
   return 'test';
 };
 
@@ -163,10 +163,10 @@ let objectPropCast = <ObjectType>{
   foo: () => 1,
 };
 
-declare functionWithArg(arg: () => number);
+declare function functionWithArg(arg: () => number);
 functionWithArg(() => 1);
 
-declare functionWithObjectArg(arg: { method: () => number });
+declare function functionWithObjectArg(arg: { method: () => number });
 functionWithObjectArg({
   method() {
     return 1;
@@ -267,7 +267,7 @@ function foo<T>(t: T): T {
 
 const bar = <T>(t: T): T => t;
 
-const allowedFunction(x: string) {
+function allowedFunction(x: string) {
   return x;
 }