From e77be94a1202ebd4a6ba01a21c6d8dd770ac9e62 Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Thu, 4 Jan 2024 18:21:46 -0500 Subject: [PATCH 1/7] docs: update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index ec90afca02eb..b9ecfe712f97 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -81,10 +81,13 @@ There are many rules that do single file static analysis, but we provide the fol We recommend you do not use the following rules, as TypeScript provides the same checks as part of standard type checking: +- `import/extensions` - `import/named` - `import/namespace` - `import/default` - `import/no-named-as-default-member` +- `import/no-unresolved` +- `import/unambiguous` The following rules do not have equivalent checks in TypeScript, so we recommend that you only run them at CI/push time, to lessen the local performance burden. From 7aa1f4724fa8c02fee18a1bb88bbdf82edcdcd14 Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Thu, 4 Jan 2024 18:25:01 -0500 Subject: [PATCH 2/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index b9ecfe712f97..93f2bb85852b 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -81,7 +81,6 @@ There are many rules that do single file static analysis, but we provide the fol We recommend you do not use the following rules, as TypeScript provides the same checks as part of standard type checking: -- `import/extensions` - `import/named` - `import/namespace` - `import/default` From aaecc11d6b09c96cb9475ff53f6f145ae569ef7e Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Thu, 4 Jan 2024 18:27:32 -0500 Subject: [PATCH 3/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index 93f2bb85852b..bea21d3afd0c 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -101,7 +101,7 @@ The following rules do not have equivalent checks in TypeScript, so we recommend If you want to enforce file extensions are always used and you're **NOT** using `moduleResolution` `node16` or `nodenext`, then there's not really a good alternative for you, and you should continue using the `import/extensions` lint rule. -If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! +If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! (However, the lint rule is still extremely useful as a one-time project-wide autofixer if you are switching from no file extensions --> file extensions, or vice versa.) #### Enforcing extensions are not used From 88b7b8a1b6002fd0368343b210bdd4fd1b656c9f Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Thu, 11 Jan 2024 14:49:59 -0500 Subject: [PATCH 4/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index bea21d3afd0c..ba8b7ced223b 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -101,7 +101,7 @@ The following rules do not have equivalent checks in TypeScript, so we recommend If you want to enforce file extensions are always used and you're **NOT** using `moduleResolution` `node16` or `nodenext`, then there's not really a good alternative for you, and you should continue using the `import/extensions` lint rule. -If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! (However, the lint rule is still extremely useful as a one-time project-wide autofixer if you are switching from no file extensions --> file extensions, or vice versa.) +If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! (However, the lint rule is still extremely useful as a one-time project-wide fixer if you are switching from no file extensions --> file extensions, or vice versa.) #### Enforcing extensions are not used From 09fe683e0c41710a4f2e22282dea1dfb531a4c15 Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Thu, 11 Jan 2024 15:03:49 -0500 Subject: [PATCH 5/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index ba8b7ced223b..93f2bb85852b 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -101,7 +101,7 @@ The following rules do not have equivalent checks in TypeScript, so we recommend If you want to enforce file extensions are always used and you're **NOT** using `moduleResolution` `node16` or `nodenext`, then there's not really a good alternative for you, and you should continue using the `import/extensions` lint rule. -If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! (However, the lint rule is still extremely useful as a one-time project-wide fixer if you are switching from no file extensions --> file extensions, or vice versa.) +If you want to enforce file extensions are always used and you **ARE** using `moduleResolution` `node16` or `nodenext`, then you don't need to use the lint rule at all because TypeScript will automatically enforce that you include extensions! #### Enforcing extensions are not used From 6b8f1eb8e53905ca67039a6a7a3469856185d270 Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Sat, 13 Jan 2024 08:20:30 -0500 Subject: [PATCH 6/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index 93f2bb85852b..a92d0ab72ee9 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -86,7 +86,6 @@ We recommend you do not use the following rules, as TypeScript provides the same - `import/default` - `import/no-named-as-default-member` - `import/no-unresolved` -- `import/unambiguous` The following rules do not have equivalent checks in TypeScript, so we recommend that you only run them at CI/push time, to lessen the local performance burden. From 6bd2063e49ee2fb344d932c7b4884ef17ebec8ac Mon Sep 17 00:00:00 2001 From: James <5511220+Zamiell@users.noreply.github.com> Date: Sat, 13 Jan 2024 08:22:29 -0500 Subject: [PATCH 7/7] Update Performance.mdx --- docs/linting/troubleshooting/Performance.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/linting/troubleshooting/Performance.mdx b/docs/linting/troubleshooting/Performance.mdx index a92d0ab72ee9..71523c0db210 100644 --- a/docs/linting/troubleshooting/Performance.mdx +++ b/docs/linting/troubleshooting/Performance.mdx @@ -85,7 +85,7 @@ We recommend you do not use the following rules, as TypeScript provides the same - `import/namespace` - `import/default` - `import/no-named-as-default-member` -- `import/no-unresolved` +- `import/no-unresolved` (as long as you are using [`import` over `require`](https://typescript-eslint.io/rules/no-var-requires/)) The following rules do not have equivalent checks in TypeScript, so we recommend that you only run them at CI/push time, to lessen the local performance burden.