From df6ba9c99bc5f2abb5511079ad68c67272a436a1 Mon Sep 17 00:00:00 2001 From: Armano Date: Sun, 20 Jan 2019 00:40:05 +0100 Subject: [PATCH] test(plugin-tslint): update tslint tests --- .../eslint-plugin-tslint/tests/index.spec.ts | 39 +++++++------------ .../tests/ast-alignment/fixtures-to-test.ts | 5 +-- 2 files changed, 15 insertions(+), 29 deletions(-) diff --git a/packages/eslint-plugin-tslint/tests/index.spec.ts b/packages/eslint-plugin-tslint/tests/index.spec.ts index 1b78c3943f85..8232a16ec21c 100644 --- a/packages/eslint-plugin-tslint/tests/index.spec.ts +++ b/packages/eslint-plugin-tslint/tests/index.spec.ts @@ -2,18 +2,19 @@ import { rules } from '../src/index'; import { RuleTester } from 'eslint'; import { readFileSync } from 'fs'; -const ruleTester = new RuleTester(); - -const parserOptions: any = { - ecmaVersion: 6, - sourceType: 'module', - ecmaFeatures: {}, - /** - * Project is needed to generate the parserServices - * within @typescript-eslint/parser - */ - project: './tests/tsconfig.json' -}; +const ruleTester = new RuleTester({ + parserOptions: { + ecmaVersion: 6, + sourceType: 'module', + ecmaFeatures: {}, + /** + * Project is needed to generate the parserServices + * within @typescript-eslint/parser + */ + project: './tests/tsconfig.json' + }, + parser: '@typescript-eslint/parser' +}); /** * Inline rules should be supported @@ -40,8 +41,6 @@ ruleTester.run('tslint/config', rules.config, { valid: [ { code: 'var foo = true;', - parser: '@typescript-eslint/parser', - parserOptions, options: [tslintRulesConfig] }, { @@ -50,9 +49,7 @@ ruleTester.run('tslint/config', rules.config, { /\n/g, ' ' ), - parser: '@typescript-eslint/parser', parserOptions: { - ...parserOptions, project: `${__dirname}/test-project/tsconfig.json` }, options: [ @@ -63,8 +60,6 @@ ruleTester.run('tslint/config', rules.config, { }, { code: 'throw "should be ok because rule is not loaded";', - parser: '@typescript-eslint/parser', - parserOptions, options: [tslintRulesConfig] } ], @@ -72,8 +67,6 @@ ruleTester.run('tslint/config', rules.config, { invalid: [ { options: [{ lintFile: './tests/test-project/tslint.json' }], - parser: '@typescript-eslint/parser', - parserOptions, code: 'throw "err" // no-string-throw', errors: [ { @@ -84,8 +77,6 @@ ruleTester.run('tslint/config', rules.config, { }, { code: 'var foo = true // semicolon', - parser: '@typescript-eslint/parser', - parserOptions, options: [tslintRulesConfig], output: 'var foo = true // semicolon', errors: [ @@ -98,8 +89,6 @@ ruleTester.run('tslint/config', rules.config, { }, { code: 'var foo = true // fail', - parser: '@typescript-eslint/parser', - parserOptions, options: [tslintRulesDirectoryConfig], output: 'var foo = true // fail', errors: [ @@ -116,9 +105,7 @@ ruleTester.run('tslint/config', rules.config, { /\n/g, ' ' ), - parser: '@typescript-eslint/parser', parserOptions: { - ...parserOptions, project: `${__dirname}/test-project/tsconfig.json` }, options: [ diff --git a/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts b/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts index 22bddf6b7baf..178b86573537 100644 --- a/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts +++ b/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts @@ -352,9 +352,8 @@ tester.addFixturePatternConfig('typescript/basics', { */ 'interface-with-extends-member-expression', /** - * Babel bug for parsing exported abstract interface - * https://github.com/babel/babel/issues/9304 - * PR: https://github.com/babel/babel/pull/9336 + * PR for parsing exported abstract interface has been merged into Babel: https://github.com/babel/babel/pull/9336 + * TODO: remove me in next babel > 7.2.3 */ 'abstract-interface', /**