Skip to content

feat(utils): improve eslint types #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

feat(utils): improve eslint types #8344

merged 1 commit into from
Feb 3, 2024

Conversation

bradzacher
Copy link
Member

Overview

More splitting out of #7935.

  • Loosen parser types in flat configs to allow for non-typescript-estree parsers
  • Loosen plugin types to allow for not-yet-updated plugins to be passed to flat configs
  • Add some missing features added in newer v8 versions

@bradzacher bradzacher added the enhancement New feature or request label Feb 2, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d35c5d9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bc4dafcb04da000847e775
😎 Deploy Preview https://deploy-preview-8344--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de6ee2) 87.70% compared to head (d35c5d9) 87.71%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8344      +/-   ##
==========================================
+ Coverage   87.70%   87.71%   +0.01%     
==========================================
  Files         397      397              
  Lines       13950    13963      +13     
  Branches     4055     4061       +6     
==========================================
+ Hits        12235    12248      +13     
  Misses       1403     1403              
  Partials      312      312              
Flag Coverage Δ
unittest 87.71% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/utils/src/ts-eslint/Linter.ts 50.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bradzacher bradzacher merged commit 16eba34 into main Feb 3, 2024
@bradzacher bradzacher deleted the eslint-type-fixes branch February 3, 2024 00:48
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants