chore(website): display tsconfig errors in playground #8666
Conversation
|
Thanks for the PR, @arka1002! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8666 +/- ##
==========================================
+ Coverage 87.21% 87.23% +0.02%
==========================================
Files 251 251
Lines 12315 12319 +4
Branches 3883 3884 +1
==========================================
+ Hits 10740 10746 +6
+ Misses 1305 1303 -2
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more. |
| source: 'eslint', | ||
| ruleId: '', | ||
| severity: 2, | ||
| nodeType: '', | ||
| column: 1, | ||
| line: 1, | ||
| message: String(e instanceof Error ? e.message : e), |
There was a problem hiding this comment.
You are reporting it as a lint error as if it's coming from our tool. It would be better described as coming from TypeScript and should be reported as if it's a type-checking error.
There was a problem hiding this comment.
Thanks for the review.
After revisiting it, I feel like I can't solve it(I really cant understand how the monaco editor works 😅)
I'll close this pr.
PR Checklist
Overview
I'm not really sure if this is the correct fix/not