From 3075bd64a6520fdc0405ce0e0b5bd1453b45034c Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 18 Mar 2024 18:18:58 -0400 Subject: [PATCH 1/3] fix(eslint-plugin): [no-floating-promises] revert disable of ignoreVoid in strict config --- packages/eslint-plugin/src/rules/no-floating-promises.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/eslint-plugin/src/rules/no-floating-promises.ts b/packages/eslint-plugin/src/rules/no-floating-promises.ts index 9e439118747f..b3ac65296992 100644 --- a/packages/eslint-plugin/src/rules/no-floating-promises.ts +++ b/packages/eslint-plugin/src/rules/no-floating-promises.ts @@ -50,10 +50,7 @@ export default createRule({ docs: { description: 'Require Promise-like statements to be handled appropriately', - recommended: { - recommended: true, - strict: [{ ignoreVoid: false }], - }, + recommended: 'recommended', requiresTypeChecking: true, }, hasSuggestions: true, From 2758b093c50b9378556c123c05e9e76acba3b429 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 18 Mar 2024 18:32:21 -0400 Subject: [PATCH 2/3] Reverted inlines too --- packages/repo-tools/src/postinstall.mts | 3 +-- packages/rule-tester/src/utils/config-validator.ts | 3 +-- packages/website/src/hooks/useClipboard.ts | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/repo-tools/src/postinstall.mts b/packages/repo-tools/src/postinstall.mts index b89cb17cc867..5facbf0defc9 100644 --- a/packages/repo-tools/src/postinstall.mts +++ b/packages/repo-tools/src/postinstall.mts @@ -20,8 +20,7 @@ if (process.env.SKIP_POSTINSTALL) { process.exit(0); } -// eslint-disable-next-line @typescript-eslint/no-floating-promises -(async function (): Promise { +void (async function (): Promise { // make sure we're running from the workspace root const { default: { workspaceRoot }, diff --git a/packages/rule-tester/src/utils/config-validator.ts b/packages/rule-tester/src/utils/config-validator.ts index ff616a0e57de..ac90b8c21eea 100644 --- a/packages/rule-tester/src/utils/config-validator.ts +++ b/packages/rule-tester/src/utils/config-validator.ts @@ -78,8 +78,7 @@ function validateRuleSchema( const validateRule = ruleValidators.get(rule); if (validateRule) { - // eslint-disable-next-line @typescript-eslint/no-floating-promises - validateRule(localOptions); + void validateRule(localOptions); if (validateRule.errors) { throw new Error( validateRule.errors diff --git a/packages/website/src/hooks/useClipboard.ts b/packages/website/src/hooks/useClipboard.ts index d8191784f8e2..0a98af33b91b 100644 --- a/packages/website/src/hooks/useClipboard.ts +++ b/packages/website/src/hooks/useClipboard.ts @@ -9,7 +9,7 @@ export function useClipboard(code: () => string): useClipboardResult { const copy = useCallback(() => { // eslint-disable-next-line @typescript-eslint/no-floating-promises - navigator.clipboard.writeText(code()).then(() => { + void navigator.clipboard.writeText(code()).then(() => { setCopied(true); }); }, [setCopied, code]); From d0eada0684b1dea5ec99fc61b5954d08bbaa42ee Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 18 Mar 2024 18:42:05 -0400 Subject: [PATCH 3/3] yarn generate-configs --- .../eslint-plugin/src/configs/strict-type-checked-only.ts | 2 +- packages/eslint-plugin/src/configs/strict-type-checked.ts | 2 +- .../src/configs/strict-type-checked-only.ts | 5 +---- .../typescript-eslint/src/configs/strict-type-checked.ts | 5 +---- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts index cbfaa5b73b80..7f60694d10ab 100644 --- a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts +++ b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts @@ -15,7 +15,7 @@ export = { '@typescript-eslint/no-base-to-string': 'error', '@typescript-eslint/no-confusing-void-expression': 'error', '@typescript-eslint/no-duplicate-type-constituents': 'error', - '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: false }], + '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/no-for-in-array': 'error', 'no-implied-eval': 'off', '@typescript-eslint/no-implied-eval': 'error', diff --git a/packages/eslint-plugin/src/configs/strict-type-checked.ts b/packages/eslint-plugin/src/configs/strict-type-checked.ts index 6d838db31566..d56d87d4ca3a 100644 --- a/packages/eslint-plugin/src/configs/strict-type-checked.ts +++ b/packages/eslint-plugin/src/configs/strict-type-checked.ts @@ -27,7 +27,7 @@ export = { '@typescript-eslint/no-explicit-any': 'error', '@typescript-eslint/no-extra-non-null-assertion': 'error', '@typescript-eslint/no-extraneous-class': 'error', - '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: false }], + '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/no-for-in-array': 'error', 'no-implied-eval': 'off', '@typescript-eslint/no-implied-eval': 'error', diff --git a/packages/typescript-eslint/src/configs/strict-type-checked-only.ts b/packages/typescript-eslint/src/configs/strict-type-checked-only.ts index 4c52c09b7376..a7947878da6e 100644 --- a/packages/typescript-eslint/src/configs/strict-type-checked-only.ts +++ b/packages/typescript-eslint/src/configs/strict-type-checked-only.ts @@ -23,10 +23,7 @@ export default ( '@typescript-eslint/no-base-to-string': 'error', '@typescript-eslint/no-confusing-void-expression': 'error', '@typescript-eslint/no-duplicate-type-constituents': 'error', - '@typescript-eslint/no-floating-promises': [ - 'error', - { ignoreVoid: false }, - ], + '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/no-for-in-array': 'error', 'no-implied-eval': 'off', '@typescript-eslint/no-implied-eval': 'error', diff --git a/packages/typescript-eslint/src/configs/strict-type-checked.ts b/packages/typescript-eslint/src/configs/strict-type-checked.ts index e53f57934cea..fa0e7af8c0ba 100644 --- a/packages/typescript-eslint/src/configs/strict-type-checked.ts +++ b/packages/typescript-eslint/src/configs/strict-type-checked.ts @@ -35,10 +35,7 @@ export default ( '@typescript-eslint/no-explicit-any': 'error', '@typescript-eslint/no-extra-non-null-assertion': 'error', '@typescript-eslint/no-extraneous-class': 'error', - '@typescript-eslint/no-floating-promises': [ - 'error', - { ignoreVoid: false }, - ], + '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/no-for-in-array': 'error', 'no-implied-eval': 'off', '@typescript-eslint/no-implied-eval': 'error',