fix(rule-tester): re-apply updates from main #9180
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -222,7 +221,6 @@ describe('RuleTester', () => { | |||
| "parserOptions": { | |||
| "disallowAutomaticSingleRunInference": true, | |||
| "project": "tsconfig.test-specific.json", | |||
| "projectService": false, | |||
| "tsconfigRootDir": "/set/in/the/test/", | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
It looks like these lines “projectService”: false were added in #9084 (right before the bad merge commit). Do we really need to remove them? (I'm not 100% sure, just asking.)
There was a problem hiding this comment.
They don't seem to be changing anything. So I'll just remove them here.
PR Checklist
Overview
Re-applies changes from #8883 - essentially undoing the accidentally reverts I'd applied.
Hooray, long-lived branches! 🙌