Skip to content

feat(typescript-estree): also remove projectService in withoutProjectParserOptions #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2024
Merged

feat(typescript-estree): also remove projectService in withoutProjectParserOptions #9287

merged 2 commits into from
Jun 8, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds the new projectService key to the list of removed keys.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 6, 2024 00:48
@netlify Netlify
Copy link

netlify bot commented Jun 6, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b7ff958
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66610791ba65a500088fa940
😎 Deploy Preview https://deploy-preview-9287--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b7ff958. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(typescript-estree): also remove projectService in withoutProject… feat(typescript-estree): also remove projectService in withoutProjectParserOptions Jun 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jun 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3c3370f into typescript-eslint:v8 Jun 8, 2024
67 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-without-project-service-option branch June 8, 2024 13:50
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 8, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @JamesHenry