Skip to content

fix(eslint-plugin): [no-redundant-type-constituents] differentiate a types-error any from a true any #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Jul 13, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4913e02
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669c8295d49f2c0008146811
😎 Deploy Preview https://deploy-preview-9555--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@y-hsgw y-hsgw changed the title fix: support error type fix(eslint-plugin): [no-redundant-type-constituents] differentiate a types-error any from a true any Jul 13, 2024
Copy link

nx-cloud bot commented Jul 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4913e02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (8ceca98) to head (4913e02).
Report is 250 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9555      +/-   ##
==========================================
+ Coverage   88.37%   88.45%   +0.07%     
==========================================
  Files         419      422       +3     
  Lines       14618    14698      +80     
  Branches     4279     4302      +23     
==========================================
+ Hits        12919    13001      +82     
+ Misses       1375     1372       -3     
- Partials      324      325       +1     
Flag Coverage Δ
unittest 88.45% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plugin/src/rules/no-redundant-type-constituents.ts 94.07% <100.00%> (+0.16%) ⬆️

... and 23 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this! 🙌

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jul 20, 2024
@y-hsgw y-hsgw requested a review from JoshuaKGoldberg July 21, 2024 03:54
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 21, 2024
@@ -201,6 +205,7 @@ export default createRule({
primitiveOverridden: `{{primitive}} is overridden by the {{literal}} in this intersection type.`,
overridden: `'{{typeName}}' is overridden by other types in this {{container}} type.`,
overrides: `'{{typeName}}' overrides all other types in this {{container}} type.`,
errorTypeOverrides: `'{{typeName}}' is an 'error' type that acts as 'any' and overrides all other types in this {{container}} type.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 beautiful.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve Carell and Will Ferrell dressed in suits from the movie Anchorman, laughing and dancing happily

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8087d17 into typescript-eslint:main Aug 19, 2024
69 checks passed
@y-hsgw y-hsgw deleted the fix/no-redundant-type-constituents branch August 19, 2024 11:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-redundant-type-constituents] Differentiate a types-error any from a "true" any
2 participants