From e450e75aff9580a5028241385efab6ad1cb36123 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 19 Jul 2024 11:09:40 -0400 Subject: [PATCH] feat(eslint-plugin): [return-await] promote to recommended: strict --- packages/eslint-plugin/src/configs/strict-type-checked-only.ts | 2 ++ packages/eslint-plugin/src/configs/strict-type-checked.ts | 2 ++ packages/eslint-plugin/src/rules/return-await.ts | 1 + .../typescript-eslint/src/configs/strict-type-checked-only.ts | 2 ++ packages/typescript-eslint/src/configs/strict-type-checked.ts | 2 ++ 5 files changed, 9 insertions(+) diff --git a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts index 53f13d96748f..9f93719a513d 100644 --- a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts +++ b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts @@ -64,6 +64,8 @@ export = { allowNever: false, }, ], + 'no-return-await': 'off', + '@typescript-eslint/return-await': 'error', '@typescript-eslint/unbound-method': 'error', '@typescript-eslint/use-unknown-in-catch-callback-variable': 'error', }, diff --git a/packages/eslint-plugin/src/configs/strict-type-checked.ts b/packages/eslint-plugin/src/configs/strict-type-checked.ts index 11d65130de62..71970b899d9b 100644 --- a/packages/eslint-plugin/src/configs/strict-type-checked.ts +++ b/packages/eslint-plugin/src/configs/strict-type-checked.ts @@ -97,6 +97,8 @@ export = { allowNever: false, }, ], + 'no-return-await': 'off', + '@typescript-eslint/return-await': 'error', '@typescript-eslint/triple-slash-reference': 'error', '@typescript-eslint/unbound-method': 'error', '@typescript-eslint/unified-signatures': 'error', diff --git a/packages/eslint-plugin/src/rules/return-await.ts b/packages/eslint-plugin/src/rules/return-await.ts index ab4534d2a269..6ce675b4f931 100644 --- a/packages/eslint-plugin/src/rules/return-await.ts +++ b/packages/eslint-plugin/src/rules/return-await.ts @@ -29,6 +29,7 @@ export default createRule({ meta: { docs: { description: 'Enforce consistent awaiting of returned promises', + recommended: 'strict', requiresTypeChecking: true, extendsBaseRule: 'no-return-await', }, diff --git a/packages/typescript-eslint/src/configs/strict-type-checked-only.ts b/packages/typescript-eslint/src/configs/strict-type-checked-only.ts index 415dd3eb342b..3cde0649c463 100644 --- a/packages/typescript-eslint/src/configs/strict-type-checked-only.ts +++ b/packages/typescript-eslint/src/configs/strict-type-checked-only.ts @@ -73,6 +73,8 @@ export default ( allowNever: false, }, ], + 'no-return-await': 'off', + '@typescript-eslint/return-await': 'error', '@typescript-eslint/unbound-method': 'error', '@typescript-eslint/use-unknown-in-catch-callback-variable': 'error', }, diff --git a/packages/typescript-eslint/src/configs/strict-type-checked.ts b/packages/typescript-eslint/src/configs/strict-type-checked.ts index fb53665756e3..8527ccabe3b9 100644 --- a/packages/typescript-eslint/src/configs/strict-type-checked.ts +++ b/packages/typescript-eslint/src/configs/strict-type-checked.ts @@ -106,6 +106,8 @@ export default ( allowNever: false, }, ], + 'no-return-await': 'off', + '@typescript-eslint/return-await': 'error', '@typescript-eslint/triple-slash-reference': 'error', '@typescript-eslint/unbound-method': 'error', '@typescript-eslint/unified-signatures': 'error',