-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: add dedicated TypeOrValueSpecifier docs page #9875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add dedicated TypeOrValueSpecifier docs page #9875
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 42bc6da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
@@ -204,6 +204,10 @@ h6 { | |||
text-decoration: underline; | |||
} | |||
|
|||
.markdown a:has(code) { | |||
text-underline-offset: 0.25em; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I really don't have a preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @abrahamguo & @marekdedic & @RebeccaStevens 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9875 +/- ##
=======================================
Coverage 88.05% 88.05%
=======================================
Files 407 407
Lines 13947 13947
Branches 4071 4071
=======================================
Hits 12281 12281
Misses 1354 1354
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e5d1ac4
into
typescript-eslint:main
PR Checklist
Overview
Adds a dedicated docs page, cross-linked with the generated TypeDocs and each rule options page.
I mentioned everything in the issue except the recommendation to not use this. I think the individual rule options do a more convincing job of advocating for that.
💖