Skip to content

Adding additional options for tsserver's configure request #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
romandecker opened this issue Mar 20, 2020 · 6 comments
Closed

Adding additional options for tsserver's configure request #143

romandecker opened this issue Mar 20, 2020 · 6 comments

Comments

@romandecker
Copy link

romandecker commented Mar 20, 2020 •
edited
Loading

Hey there!

I'm looking to support more options (mainly importModuleSpecifier, but theoretically any of the options defined here) for tsserver's configure request. I see that you already send a configure request as part of the initialization phase, so it should be relatively simple to add more options there.

I'm happy to implement it myself - would you accept a PR for this?
@PyvesB
Copy link
Contributor

PyvesB commented Mar 20, 2020

I'm happy to implement it myself - would you accept a PR for this?

The project is looking for additional maintainers - see here: #141 😉

@DonnieWest
Copy link
Collaborator

If you're still interested, I'm accepting PRs :)

@blahgeek
Copy link

blahgeek commented Feb 27, 2021 •
edited
Loading

+1 for this!

Also, currently the includeExternalModuleExports and includeInsertTextCompletions options are always set in completion request in https://github.com/theia-ide/typescript-language-server/blob/3a8ea0f04bde047e2f60b9f68ef7816e3a41aa10/server/src/lsp-server.ts#L444. They are deprecated and user preferences should be used instead https://github.com/microsoft/TypeScript/blob/a2f09ed4fc3747629036cb1c10b30809c47f42a4/src/server/protocol.ts#L2141. If we can support additional options for configure request, we should also remove them.

@romandecker
Copy link
Author

Hello there,

sorry to disappoint - due to other obligations I won't have time to implement a PR for this - I actually had to move away from typescript-language-server and am just using vscode atm.

So anybody is welcome to pick this up and start working on it!

@dnjstrom dnjstrom mentioned this issue Jun 8, 2021
Merged
@apexskier
Copy link
Contributor

This is resolved by #218.

@rchl
Copy link
Member

rchl commented Jul 5, 2021

Agreed.

Also handling the issue mentioned in #143 (comment) in #233

@rchl rchl closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rchl @apexskier @romandecker @blahgeek @DonnieWest @PyvesB