-
Notifications
You must be signed in to change notification settings - Fork 167
Diagnostics across files within a project #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd also very much like to see this feature come to life if possible. I currently use |
I have never used or thought of this, this would be pretty useful. |
coc-tsserver appears to implement something like that at https://github.com/neoclide/coc-tsserver/blob/master/src/server/features/watchBuild.ts. It looks like it just compiles the whole project using |
@rchl interesting. I'm not well versed enough to make a statement as to where workspace-wide diagnostic capabilities belong, although my intuition tells me it would belong in the LS itself. That being said, I understand where you're coming from. It doesn't seem like the implementation in |
@rchl That's what prompted me to bring this discussion up. Additionally IntelliJ/Webstorm is able to compile a project and display a Typescript error panel that essentially is similar to how coc-tsserver's diagnostics compiles projects and renders its results in the vim/neovim quickfix window. |
The thing is that both of them do it more on the client/editor side which is more or less a requirement because the LSP spec doesn't really provide a good way to implement that. On the LSP side there are diagnostics but putting build results in the same bag doesn't quite make sense. So I don't think this feature can really be done in this language server. Or even if can be done, it wouldn't work that well and is not really the correct way to do it IMO. |
@rchl Do you think this feature request should be passed back to the sublime/LSP side of things, or another package is required to implement some sort of hybrid with the typescript-language-server to render the build results? |
@agreco yes, at this point I think that that would be a correct place. Sorry for sending you back and forth. :) |
In the Neovim world, I've seen a lot of people using projects like https://github.com/iamcco/diagnostic-languageserver to implement linters via the LSP spec. It's not something I personally use, but for those replacing I'm not seeing pre-made configs though for |
I'm using it for shellcheck for example but in using it for this use case, the immediate issue I see is that it would try to run compilation on each change to the document while a feature like this one should rather run on save. |
i can recommend neomake for diagnostics across a project / workspace screen1_recording_2021-09-20_21-49-15.mp4 |
@danielnehrig the video file seems to be corrupt. |
@rchl i can play it back on all of my devices (mac and linux) |
Didn't work in firefox but I can watch it in Chrome. It seems like that method works through manual invocation of a command. So in Sublime Text, for example, that could be similarly achieved through a build system. |
As discussed above, a feature like that fits better on the client/editor side so I'll close this issue. |
Uh oh!
There was an error while loading. Please reload this page.
Hey,
I've been using this LSP server with a lot of success on my projects.
There is one feature I think is still missing, which is the ability to use the LSP diagnostics panel to show all errors/warnings across files within a project. To determine if a project has any issues I have to compile the project from outside ST.
I raised the same issue here: sublimelsp/LSP#1803 and here: sublimelsp/LSP-typescript#73, and the advice was that type of feature would need to be handled by the LSP server in question and may not be a possible option in
tsserver
Would it be possible to implement such a feature?
Hope this is enough info. I'd be glad to elaborate more if required.
Cheers
The text was updated successfully, but these errors were encountered: