add tsserver.fallbackPath to initialization options #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the broad variety of projects that replit users encounter, we at replit have been explicitly passing the
typescriptpackage fromnixpkgstotypescript-language-serversince April of last year. This has the unfortunate side-effect of not using thetsserverthat's available in the user's workspace, which means the user may get inaccurate results in their completions.This PR introduces a new option to
initializationOptions.tsserver,fallbackPath. It has similar semantics toinitializationOptions.tsserver.path, but is checked iftypescriptpassed viainitializationOptions.tsserver.pathis absent or invalidtypescriptavailable via the workspace is absent or invalidi've tested that this works on Replit