Skip to content

Allow mention.cluster = another_cluster #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinpopel opened this issue Feb 8, 2022 · 0 comments
Open

Allow mention.cluster = another_cluster #99

martinpopel opened this issue Feb 8, 2022 · 0 comments

Comments

@martinpopel
Copy link
Contributor

Moving a mention from one cluster to another cluster is not supported yet (but it seems @dan-zeman would like to use it). We should:

  • remove the NotImplementedError in the setter
  • add self._cluster._mentions.remove(self)
  • decide if cluster._mentions should be always sorted (and if yes, add a sort())
  • if self._bridging and new_cluster in self._bridging.targets: raise ValueError("Bridge cannot self-reference the same cluster")
  • make sure there are no other hidden problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinpopel