Skip to content

Commit 475be3b

Browse files
committed
remove header from reader
VIPS::Reader no longer includes VIPS::Header methods it was crashing, and Reader shouldn't really be used directly anyway, go through VIPS::Image.
1 parent c168f88 commit 475be3b

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
# Version 0.3.4
44

55
* Update specs for lcms changes, thanks Stanislaw [John Cupitt]
6-
* VIPS::Reader supports .exif / .exif? methods for better back compat, thanks Jeremy [John Cupitt]
7-
* VIPS::Reader fallbacks load the image if it's not been loaded [John Cupitt]
6+
* VIPS::Reader supports .exif() / .exif?() methods for better back compat, thanks Jeremy [John Cupitt]
7+
* VIPS::Reader fallbacks load the image if its not been loaded [John Cupitt]
8+
* VIPS::Reader no longer allows VIPS::Header methods [John Cupitt]
89

910
# Version 0.3.3
1011

ext/reader.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,13 @@ init_Reader(void)
8686
id_iv__vips_fmt = rb_intern("@_vips_fmt");
8787

8888
VALUE reader = rb_define_class_under(mVIPS, "Reader", rb_cObject);
89+
90+
/* We used to allow header methods on VIPS::Reader, we don't any more
91+
*
92+
* lib/vips/reader.rb includes a few header methods for back compat
93+
*
8994
rb_include_module(reader, mVIPSHeader);
95+
*/
9096
rb_define_alloc_func(reader, img_alloc);
9197

9298
rb_define_singleton_method(reader, "recognized?", reader_s_recognized_p, 1);

0 commit comments

Comments
 (0)