now works on Ubuntu 12.10

jcupitt · jcupitt · commit c2af32b60fc9 · 2012-11-15T12:18:55.000Z
An rb_raise() in mask.c was using a string pointer as the fmt arg. gcc
on 12.10 flags this as an error due to the obvious security problems.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # master 
 
+# Version 0.3.5
+
+* rb_raise() in mask.c no longer passes a string pointer as the fmt arg, stopping gcc bailing out on some platforms [John Cupitt]
+
 # Version 0.3.4
 
 * Update specs for lcms changes, thanks Stanislaw [John Cupitt]
diff --git a/ext/mask.c b/ext/mask.c
@@ -282,7 +282,7 @@ mask_arg2mask(VALUE arg, INTMASK **imask, DOUBLEMASK **dmask)
         else
             errstr = "Expected an int array or an int Mask";
 
-        rb_raise(rb_eArgError, errstr);
+        rb_raise(rb_eArgError, "%s", errstr);
     }
 
     if (imask)

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ mask_arg2mask(VALUE arg, INTMASK imask, DOUBLEMASK dmask)`
`282`	`282`	`else`
`283`	`283`	`errstr = "Expected an int array or an int Mask";`
`284`	`284`
`285`		`- rb_raise(rb_eArgError, errstr);`
	`285`	`+ rb_raise(rb_eArgError, "%s", errstr);`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`if (imask)`