fix refleak in null-containing error case (python#21147)

benjaminp · benjaminp · commit 26c985a8aac1 · 2016-12-03T12:01:32.000-08:00
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
@@ -74,8 +74,9 @@ int pysqlite_statement_create(pysqlite_Statement* self, pysqlite_Connection* con
         rc = PYSQLITE_SQL_WRONG_TYPE;
         return rc;
     }
-    sql_cstr = PyString_AsString(sql_str);
+    sql_cstr = PyString_AS_STRING(sql_str);
     if (strlen(sql_cstr) != (size_t)PyString_GET_SIZE(sql_str)) {
+        Py_DECREF(sql_str);
         PyErr_SetString(PyExc_ValueError, "the query contains a null character");
         return PYSQLITE_SQL_WRONG_TYPE;
     }

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,9 @@ int pysqlite_statement_create(pysqlite_Statement* self, pysqlite_Connection* con`
`74`	`74`	`rc = PYSQLITE_SQL_WRONG_TYPE;`
`75`	`75`	`return rc;`
`76`	`76`	`}`
`77`		`- sql_cstr = PyString_AsString(sql_str);`
	`77`	`+ sql_cstr = PyString_AS_STRING(sql_str);`
`78`	`78`	`if (strlen(sql_cstr) != (size_t)PyString_GET_SIZE(sql_str)) {`
	`79`	`+ Py_DECREF(sql_str);`
`79`	`80`	`PyErr_SetString(PyExc_ValueError, "the query contains a null character");`
`80`	`81`	`return PYSQLITE_SQL_WRONG_TYPE;`
`81`	`82`	`}`