bpo-31174: Improve the code of test_tools.test_unparse. (python#4146)

serhiy-storchaka · web-flow · commit 7351f9e5a91c · 2017-10-27T15:35:11.000+03:00
diff --git a/Lib/test/test_tools/test_unparse.py b/Lib/test/test_tools/test_unparse.py
@@ -268,12 +268,13 @@ class DirectoryTestCase(ASTTestCase):
     # test directories, relative to the root of the distribution
     test_directories = 'Lib', os.path.join('Lib', 'test')
 
-    def get_names(self):
-        if DirectoryTestCase.NAMES is not None:
-            return DirectoryTestCase.NAMES
+    @classmethod
+    def get_names(cls):
+        if cls.NAMES is not None:
+            return cls.NAMES
 
         names = []
-        for d in self.test_directories:
+        for d in cls.test_directories:
             test_dir = os.path.join(basepath, d)
             for n in os.listdir(test_dir):
                 if n.endswith('.py') and not n.startswith('bad'):
@@ -282,10 +283,9 @@ def get_names(self):
         # Test limited subset of files unless the 'cpu' resource is specified.
         if not test.support.is_resource_enabled("cpu"):
             names = random.sample(names, 10)
-            # bpo-31174: Store the names sample to always test the same files.
-            # It prevents false alarms when hunting reference leaks.
-            DirectoryTestCase.NAMES = names
-
+        # bpo-31174: Store the names sample to always test the same files.
+        # It prevents false alarms when hunting reference leaks.
+        cls.NAMES = names
         return names
 
     def test_files(self):
