Revert r52798, r52803, r52824, r54342, as they don't fix

loewis · loewis · commit 80bdb4841cca · 2008-03-02T17:15:58.000Z
security issues.
diff --git a/Lib/email/Charset.py b/Lib/email/Charset.py
@@ -1,5 +1,5 @@
-# Copyright (C) 2001-2007 Python Software Foundation
-# Author: email-sig@python.org
+# Copyright (C) 2001-2006 Python Software Foundation
+# Author: che@debian.org (Ben Gertzfield), barry@python.org (Barry Warsaw)
 
 from types import UnicodeType
 from email.Encoders import encode_7or8bit
@@ -99,7 +99,7 @@ def _isunicode(s):
 # of stability and useability.
 
 CODEC_MAP = {
-    'gb2312':   'eucgb2312_cn',
+    'gb2132':   'eucgb2312_cn',
     'big5':     'big5_tw',
     'utf-8':    'utf-8',
     # Hack: We don't want *any* conversion for stuff marked us-ascii, as all
diff --git a/Lib/email/__init__.py b/Lib/email/__init__.py
@@ -1,9 +1,9 @@
-# Copyright (C) 2001-2007 Python Software Foundation
-# Author: email-sig@python.org
+# Copyright (C) 2001-2006 Python Software Foundation
+# Author: barry@python.org (Barry Warsaw)
 
 """A package for parsing, handling, and generating email messages."""
 
-__version__ = '2.5.9'
+__version__ = '2.5.8'
 
 __all__ = [
     'base64MIME',
diff --git a/Lib/fileinput.py b/Lib/fileinput.py
@@ -301,9 +301,7 @@ def readline(self):
                     self._file = open(self._backupfilename, "r")
                     try:
                         perm = os.fstat(self._file.fileno()).st_mode
-                    except (AttributeError, OSError):
-			# AttributeError occurs in Jython, where there's no
-			# os.fstat.
+                    except OSError:
                         self._output = open(self._filename, "w")
                     else:
                         fd = os.open(self._filename,
diff --git a/Lib/test/test_sha.py b/Lib/test/test_sha.py
@@ -11,23 +11,9 @@
 
 class SHATestCase(unittest.TestCase):
     def check(self, data, digest):
-        # Check digest matches the expected value
-        obj = sha.new(data)
-        computed = obj.hexdigest()
+        computed = sha.new(data).hexdigest()
         self.assert_(computed == digest)
 
-        # Verify that the value doesn't change between two consecutive
-        # digest operations.
-        computed_again = obj.hexdigest()
-        self.assert_(computed == computed_again)
-
-        # Check hexdigest() output matches digest()'s output
-        digest = obj.digest()
-        hexd = ""
-        for c in digest:
-            hexd += '%02x' % ord(c)
-        self.assert_(computed == hexd)
-
     def test_case_1(self):
         self.check("abc",
                    "a9993e364706816aba3e25717850c26c9cd0d89d")
@@ -40,9 +26,6 @@ def test_case_3(self):
         self.check("a" * 1000000,
                    "34aa973cd4c4daa4f61eeb2bdbad27316534016f")
 
-    def test_case_4(self):
-        self.check(chr(0xAA) * 80,
-                   '4ca0ef38f1794b28a8f8ee110ee79d48ce13be25')
 
 def test_main():
     test_support.run_unittest(SHATestCase)
diff --git a/Lib/uu.py b/Lib/uu.py
@@ -115,7 +115,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):
     #
     # Open the output file
     #
-    opened = False
     if out_file == '-':
         out_file = sys.stdout
     elif isinstance(out_file, StringType):
@@ -125,7 +124,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):
         except AttributeError:
             pass
         out_file = fp
-        opened = True
     #
     # Main decoding loop
     #
@@ -143,8 +141,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):
         s = in_file.readline()
     if not s:
         raise Error, 'Truncated input file'
-    if opened:
-        out_file.close()
 
 def test():
     """uuencode/uudecode main program"""

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):`
`115`	`115`	`#`
`116`	`116`	`# Open the output file`
`117`	`117`	`#`
`118`		`- opened = False`
`119`	`118`	`if out_file == '-':`
`120`	`119`	`out_file = sys.stdout`
`121`	`120`	`elif isinstance(out_file, StringType):`
`@@ -125,7 +124,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):`
`125`	`124`	`except AttributeError:`
`126`	`125`	`pass`
`127`	`126`	`out_file = fp`
`128`		`- opened = True`
`129`	`127`	`#`
`130`	`128`	`# Main decoding loop`
`131`	`129`	`#`
`@@ -143,8 +141,6 @@ def decode(in_file, out_file=None, mode=None, quiet=0):`
`143`	`141`	`s = in_file.readline()`
`144`	`142`	`if not s:`
`145`	`143`	`raise Error, 'Truncated input file'`
`146`		`- if opened:`
`147`		`- out_file.close()`
`148`	`144`
`149`	`145`	`def test():`
`150`	`146`	`"""uuencode/uudecode main program"""`