Bug python#1321: Fixed logic error in TimedRotatingFileHandler.__init__()

vsajip · vsajip · commit 80ebe95855b7 · 2007-10-24T10:51:23.000Z
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
@@ -231,11 +231,11 @@ def __init__(self, filename, when='h', interval=1, backupCount=0, encoding=None)
             #         of days in the next week until the rollover day (3).
             if when.startswith('W'):
                 day = t[6] # 0 is Monday
-                if day > self.dayOfWeek:
-                    daysToWait = (day - self.dayOfWeek) - 1
-                    self.rolloverAt = self.rolloverAt + (daysToWait * (60 * 60 * 24))
-                if day < self.dayOfWeek:
-                    daysToWait = (6 - self.dayOfWeek) + day
+                if day != self.dayOfWeek:
+                    if day < self.dayOfWeek:
+                        daysToWait = self.dayOfWeek - day - 1
+                    else:
+                        daysToWait = 6 - day + self.dayOfWeek
                     self.rolloverAt = self.rolloverAt + (daysToWait * (60 * 60 * 24))
 
         #print "Will rollover at %d, %d seconds from now" % (self.rolloverAt, self.rolloverAt - currentTime)
