Actually omit surrogate code points #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBFF is only the high surrogates...
mihnita
approved these changes
Feb 12, 2023
|
@gibson042 Was there any reason why these were left out in #290? |
echeran
approved these changes
Feb 12, 2023
|
I'm going to merge this. If there is some other reason to have only the one set of surrogates, we can fix later. |
|
Nope, looks like it was just an oversight. 👍 |
stasm
added a commit
that referenced
this pull request
Mar 6, 2023
This is a follow up to #339, which made the same change to the BNF.
aphillips
pushed a commit
that referenced
this pull request
Mar 6, 2023
This is a follow up to #339, which made the same change to the BNF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBFF is only the high surrogates...
I probably would have done this rule differently, but I noticed the typo just now and can fast-fix it.