Skip to content

Change the literal delimiter to the vertical pipe character. #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

Change the literal delimiter to the vertical pipe character. #359

merged 2 commits into from
Mar 1, 2023

Conversation

stasm
Copy link
Collaborator

@stasm stasm commented Feb 28, 2023

Closes #263.

@stasm stasm marked this pull request as draft February 28, 2023 15:56
@stasm
Copy link
Collaborator Author

stasm commented Feb 28, 2023

This PR needs to wait for #347 to land.

aphillips
aphillips requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, except for the modification of the date string.

alerque
alerque approved these changes Mar 1, 2023
View reviewed changes
Base automatically changed from sta/abnf to main March 1, 2023 08:34
@stasm stasm force-pushed the sta/pipe-literals branch from 4f1d8cf to 046be92 Compare March 1, 2023 09:12
@stasm stasm marked this pull request as ready for review March 1, 2023 09:14
@stasm
Copy link
Collaborator Author

stasm commented Mar 1, 2023

I don't seem to be able to merge this at this point due to the license/cla check not having finished. I don't see a way to restart it.

@stasm stasm merged commit d18d64f into main Mar 1, 2023
@stasm stasm deleted the sta/pipe-literals branch March 1, 2023 13:28
stasm added a commit to stasm/message-format-wg that referenced this pull request Mar 12, 2023
@stasm
Actually change literal delimiters
6b97745 
This is a follow-up to unicode-org#359, in which I changed the docs and the escape sequence productions, only to forget to edit the delimiters themselves...
@stasm stasm mentioned this pull request Mar 12, 2023
Merged
stasm added a commit that referenced this pull request Mar 16, 2023
@stasm
Actually change literal delimiters (#366)
3374dab 
This is a follow-up to #359, in which I changed the docs and the escape sequence productions, only to forget to edit the delimiters themselves...
@eemeli eemeli mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

@gibson042 gibson042 gibson042 left review comments

@aphillips aphillips aphillips approved these changes

@eemeli eemeli eemeli approved these changes

@mihnita mihnita Awaiting requested review from mihnita

@echeran echeran Awaiting requested review from echeran

@zbraniecki zbraniecki Awaiting requested review from zbraniecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pick a delimiter for literals other than the double quote
5 participants
@stasm @aphillips @alerque @eemeli @gibson042