Implement private-use separately from reserved
#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I didn't address making reserved opaque.
eemeli
requested changes
Jul 13, 2023
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
eemeli
reviewed
Jul 15, 2023
eemeli
reviewed
Jul 17, 2023
eemeli
reviewed
Jul 17, 2023
I missed this earlier.
eemeli
approved these changes
Jul 18, 2023
Comment on lines
+105
to
+106
| - Else, the _expression_ has a _reserved_ _annotation_, | ||
| an Unsupported Expression error is emitted and a fallback value is used as its value. |
There was a problem hiding this comment.
This seems like a run-on sentence, and the "it" could be specified a bit more explicitly. Yes, I realise that I'm in part correcting my own suggestion here.
Suggested change
| - Else, the _expression_ has a _reserved_ _annotation_, | |
| an Unsupported Expression error is emitted and a fallback value is used as its value. | |
| - Else, the _expression_ has a _reserved_ _annotation_. | |
| An Unsupported Expression error is emitted and | |
| the expression resolves to a fallback value. |
Comment on lines
+22
to
+23
| 1. [Private-Use Sequences](#private-use) | ||
| 2. [Reserved Sequences](#reserved) |
There was a problem hiding this comment.
We might want to start using explicit <a name="foo"></a> anchors at some point, rather than having two different names for spec sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reservedto suitNote that I did not include changing
reservedto use*(text)in this PR, but did changeprivate-useto do so.