Clarify Duplicate Declaration error #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
requested changes
Jan 5, 2024
|
I've refactored the PR to not add a new error, and instead clarify the existing Duplicate Declaration error to cover this case as well. |
aphillips
requested changes
Jan 15, 2024
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
aphillips
approved these changes
Jan 15, 2024
stasm
approved these changes
Jan 15, 2024
|
@aphillips I've resolved the conflicts, and this should now merge cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementation, I noticed that while we included this in the variable mutability design doc:
message-format-wg/exploration/variable-mutability.md
Lines 179 to 186 in fb3da4c
we missed out on accounting for that in #488. So this PR adds a Forward Reference data model error for that situation. We might also want to consider this Duplicate Declaration error as a Forward Reference error instead:
message-format-wg/spec/syntax.md
Line 181 in 2a69d2a