From b527b10e924e015944aa10a9f1a5e08aee98693d Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:17:01 -0700 Subject: [PATCH 1/8] Update design docs and their status --- exploration/code-mode-introducer.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/exploration/code-mode-introducer.md b/exploration/code-mode-introducer.md index 64b28d2f32..c1d979a212 100644 --- a/exploration/code-mode-introducer.md +++ b/exploration/code-mode-introducer.md @@ -1,6 +1,6 @@ # Design Proposal: Choosing a Code Mode Introducer -Status: **Proposed** +Status: **Accepted**
Metadata @@ -77,10 +77,9 @@ private-start = "^" / "&" _Describe the proposed solution. Consider syntax, formatting, errors, registry, tooling, interchange._ -We need to choose one of these (or another option not yet considered). -Presentation at UTW did not produce any opinions. - -Based on the pro/cons below, I would suggest Option D is possibly the best option? +A modified version of Option D was chosen. +The keyword `when` was dropped after this design was completed. +"Simple" messages do not require the `pattern` to be quoted. ## Alternatives Considered From cf236d0513e0896be809457be309481cda17a1ef Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:22:25 -0700 Subject: [PATCH 2/8] Update exact-match-selector-options.md --- exploration/exact-match-selector-options.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exploration/exact-match-selector-options.md b/exploration/exact-match-selector-options.md index d35f47dbdc..0280b04ebb 100644 --- a/exploration/exact-match-selector-options.md +++ b/exploration/exact-match-selector-options.md @@ -1,4 +1,4 @@ -# Design Proposal Template +# Name of the "Exact Match" selector function Status: **Accepted** From 91a596e2125b4b6296097423781d3ed60f3e497b Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:28:07 -0700 Subject: [PATCH 3/8] Update quoted-literals.md --- exploration/quoted-literals.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exploration/quoted-literals.md b/exploration/quoted-literals.md index e46d7451c7..6eba257ed5 100644 --- a/exploration/quoted-literals.md +++ b/exploration/quoted-literals.md @@ -1,6 +1,6 @@ # Quoted Literals -Status: **Proposed** +Status: **Accepted**
Metadata From 1d3411563d89445fd80f8ab3d5a87ff349af05fd Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:32:56 -0700 Subject: [PATCH 4/8] Update selection-matching-options.md --- exploration/selection-matching-options.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/exploration/selection-matching-options.md b/exploration/selection-matching-options.md index b632e44acd..7b6a093508 100644 --- a/exploration/selection-matching-options.md +++ b/exploration/selection-matching-options.md @@ -1,5 +1,20 @@ # Selection Matching Options +Status: **Obsolete** + +
+ Metadata +
+
Contributors
+
@aphillips
+
+
+ +> [!NOTE] +> This document was used as part of the discussion for choosing the type of matching. +> It is preserved for historical reasons, but does not conform to the format of a +> normal design document. + ## Recommendation We are discussing whether to change First-Match to another value. Currently voting looks like: From 60f4dfe9a195e1529afaad9c2b1ed54678fe5039 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:34:21 -0700 Subject: [PATCH 5/8] Update string-selection-formatting.md --- exploration/string-selection-formatting.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exploration/string-selection-formatting.md b/exploration/string-selection-formatting.md index aa7b7d8018..8c00268ffa 100644 --- a/exploration/string-selection-formatting.md +++ b/exploration/string-selection-formatting.md @@ -1,6 +1,6 @@ # Selection and Formatting on String Values -Status: **Proposed** +Status: **Accepted**
Metadata From 8a0d377f7341badaaf40e5fa0907061b49db7255 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:36:26 -0700 Subject: [PATCH 6/8] Update variable-mutability.md --- exploration/variable-mutability.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exploration/variable-mutability.md b/exploration/variable-mutability.md index c7e324905f..cc1a08ab7f 100644 --- a/exploration/variable-mutability.md +++ b/exploration/variable-mutability.md @@ -1,4 +1,4 @@ -# Design Proposal Template +# Variable Mutability Status: **Accepted** From bebcd1a26b1b31d408665beb213b856494bf0e68 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 13 May 2024 16:37:57 -0700 Subject: [PATCH 7/8] Update variants.md --- exploration/variants.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/exploration/variants.md b/exploration/variants.md index c8d9922675..bc16b32f67 100644 --- a/exploration/variants.md +++ b/exploration/variants.md @@ -3,6 +3,10 @@ This is a collection of message examples which require a branching logic to handle grammatical variations of the copy. +> [!NOTE] +> This document contains examples used during design discussions. +> It is not a formal design document and is preserved for historical reasons. + ## Regular plurals ### English From 14db38ca0b6cd505733cec19ea0a228d4901115d Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Tue, 14 May 2024 07:04:23 -0700 Subject: [PATCH 8/8] Update exploration/variable-mutability.md Co-authored-by: Eemeli Aro --- exploration/variable-mutability.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exploration/variable-mutability.md b/exploration/variable-mutability.md index cc1a08ab7f..11d14750a5 100644 --- a/exploration/variable-mutability.md +++ b/exploration/variable-mutability.md @@ -1,4 +1,4 @@ -# Variable Mutability +# Variable Namespacing and Mutability Status: **Accepted**