Skip to content

jsp: half of the build time is cache files #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
srl295 opened this issue Jan 28, 2025 · 4 comments
Open

jsp: half of the build time is cache files #1012

srl295 opened this issue Jan 28, 2025 · 4 comments
Labels
JSP UnicodeJsps

Comments

@srl295
Copy link
Member

srl295 commented Jan 28, 2025

1⁄2 of the time is spent in Regenerate the property cache files

@eggrobin can this be cached safely?
@eggrobin
Copy link
Member

This is tricky. Unless the code changes, the old versions are stable (but not the dev version).
But then if the code changes, all bets are off.

@srl295
Copy link
Member Author

srl295 commented Jan 28, 2025

ok, so it could skip the dev version, and then hash on all of the code. Maybe not worth it.

@srl295
Copy link
Member Author

srl295 commented Jan 28, 2025 •
edited
Loading

The caching isn't even working, because in the JSP's console I see

2025-01-28 18:12:55.145:INFO:oejs.session:main: DefaultSessionIdManager workerName=node0
2025-01-28 18:12:55.146:INFO:oejs.session:main: No SessionScavenger set, using defaults
2025-01-28 18:12:55.146:INFO:oejs.session:main: node0 Scavenging every 660000ms
Loading back to 17.0.0.0...
Loading UCD 16.0...
Loaded non-Unihan properties for 16.0 (4303 ms)
Loaded Unihan for 16.0 (3420 ms)
Loaded UCD 16.0 in 7732 ms
Loading UCD 17.0...
Loaded non-Unihan properties for 17.0 (3423 ms)
Loaded Unihan for 17.0 (546 ms)
Loaded UCD 17.0 in 3969 ms
Loaded UCD history back to 17.0.0.0 in 11 s
2025-01-28 18:13:07.380:INFO:oejsh.ContextHandler:main: Started o.e.j.w.WebAppContext@3e27aa33{UnicodeJsps,/UnicodeJsps,file:///tmp/jetty-0_0_0_0-8080-UnicodeJsps_war-_UnicodeJsps-any-9983956548832997525/webapp/,AVAILABLE}{/var/lib/jetty/webapps/UnicodeJsps.war}
Loading back to the dawn of time...
Loading UCD 16.0...
Loaded non-Unihan properties for 16.0 (1 ms)
Loaded Unihan for 16.0 (0 ms)
Loaded UCD 16.0 in 1 ms
Loading UCD 17.0...
Loaded non-Unihan properties for 17.0 (1 ms)
Loaded Unihan for 17.0 (0 ms)
Loaded UCD 17.0 in 1 ms
Loading UCD 15.1...

that might be causing some runtime issues!

@eggrobin
Copy link
Member

That is the time spent loading the cache.

Generating the cache from the data files is more like 20 s for each version of Unicode.

@srl295 srl295 added the JSP UnicodeJsps label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JSP UnicodeJsps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srl295 @eggrobin