-
-
Notifications
You must be signed in to change notification settings - Fork 44
CheckProperties exception for RGI_Emoji_Flag_Sequence #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Running the tool just now gives me the same exception but for a different property:
|
CheckProperties was turned into a CI step by #253 for #187. But it was never written as a CI test; it was a tool you ran and whose output you read. The documentation says
This means that we are not testing whatever was only tested by that, and I do not think we are manually running this tool and looking at its output anymore either. And I think the validity of values in data files is one of those things; this would explain the |
Missing enum values are being caught by org.unicode.props.PropertyParsingInfo#checkEnum. The errors are stored in DATA_LOADING_ERRORS, but the only place that DATA_LOADING_ERRORS is being read is in CheckProperties. |
Indeed. Which would fail, if it were a thing that could fail. In fact it fails so much (because of unmaintained regexes) that the checkEnum failure isn’t actually printed (but it occurs, see the CI failure on the second commit in #1083). What a mess. I think we should change checkEnum to throw directly, and deal with the rest of the CheckProperties errors another day—the regexes are known to be out of date, for instance. @jowilco, @markusicu, what do you think? |
That works for me, but I'm not sure that I know enough to make the call. |
sgtm |
It is not too bad for the current version. |
I got curious about that. That went away in Unicode 2.1.8:
In those days, many things about Unicode were not stable that have long since been stabilized. I believe Unicode normalization was stabilized in 3.0, modulo the NormalizationCorrections until 4.1 or so. |
When I run the unicodetools "CheckProperties" I see an exception getting thrown and printed, but the program continues and exits without a failure code.
Is this something to worry about?
Comment from KenW: The only difference I am seeing between 15.0 and 15.1 is that the flag of Turkey ended up described as "flag: Türkiye"
Thoughts from Markus:
@nedley @kenlunde @macchiati
The text was updated successfully, but these errors were encountered: