From 9b24cf899e38b2f1cf5f956dc82c1cc06e9022d8 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Fri, 22 Apr 2022 15:45:23 -0700 Subject: [PATCH 01/10] Add CI command to run GenerateIdnaTest tool, update last version in code to match Unicode v15.0.0 --- .github/workflows/cli-build-instructions.yml | 14 ++++++++++++++ .../java/org/unicode/idna/GenerateIdnaTest.java | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 67736b92e..26c58369c 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -146,3 +146,17 @@ jobs: mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdna" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + # https://github.com/unicode-org/unicodetools/blob/main/docs/idna.md + - name: Run command - Generate IDNA Test + run: | + cd unicodetools/mine/src + # Confirm that the directory for the bin files exists + compgen -G "../Generated/BIN" + # "Delete all the bin files" as per instructions + rm -rf ../Generated/BIN/* + # run GenerateIdnaTest + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdnaTest" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + diff --git a/unicodetools/src/main/java/org/unicode/idna/GenerateIdnaTest.java b/unicodetools/src/main/java/org/unicode/idna/GenerateIdnaTest.java index 280d8ca86..abd18087f 100644 --- a/unicodetools/src/main/java/org/unicode/idna/GenerateIdnaTest.java +++ b/unicodetools/src/main/java/org/unicode/idna/GenerateIdnaTest.java @@ -169,7 +169,7 @@ int generateTests(int lines) throws IOException { // See https://github.com/unicode-org/unicodetools/issues/100 "Whither 13.1.0?" lastVersion = "13.0.0"; } - int ucdTypesLastVersion = UCD_Types.AGE130; + int ucdTypesLastVersion = UCD_Types.AGE140; String ucdTypesLastVersionString = UCD_Types.AGE_VERSIONS[ucdTypesLastVersion]; if (!ucdTypesLastVersionString.equals(lastVersion)) { throw new AssertionError( From c92a9a65158bda7e2d960e1670b8116065051fb9 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Mon, 2 May 2022 15:58:25 -0700 Subject: [PATCH 02/10] Add command for GenerateEnums (with workaround for fake Unicode v13.1) --- .github/workflows/cli-build-instructions.yml | 32 ++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 26c58369c..f70da08dd 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -160,3 +160,35 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # https://github.com/unicode-org/unicodetools/blob/main/docs/newunicodeproperties.md#run-generateenumsjava + - name: Run command - Generate Enums Test + run: | + cd unicodetools/mine/src + # run GenerateEnums + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.props.GenerateEnums" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + # TODO(#100) Get rid of need for fake version 13.1 of Unicode enum val + # Fail if we haven't committed changes from Generate Enums, but make exception for fake Unicode version hack (#100) + echo "Check if GenerateEnums output has been committed to repo" + git diff --compact-summary --exit-code + if [ $? -eq 0 ]; then + echo "Success: Any output from GenerateEnums has already been committed." + echo "exit 0" + else + names=`git diff --name-only` + if [[ "$names" == "unicodetools/src/main/java/org/unicode/props/UcdPropertyValues.java" ]]; then + gitdiffstat=`git diff --stat | tail -n 1` + if [[ "$gitdiffstat" = "1 file changed, 1 insertion(+), 1 deletion(-)" ]]; then + git diff | grep 'V13_1("13.1")' + if [ $? -eq 0 ]; then + echo "Inferred: Only non-committed change after GenerateEnums is temporary V13_1 hack (issue #100)" + echo "Check passed." + echo "exit 0" + fi + fi + fi + echo "Failure: GenerateEnums has changed that need to be committed." + echo "exit 1" + fi + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + From 6e0913bf5d78c36dfd422dcd9d4b1944f58150ae Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Fri, 6 May 2022 16:43:21 -0700 Subject: [PATCH 03/10] Update GenerateEnums --- .github/workflows/cli-build-instructions.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index f70da08dd..c0ed4fe87 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -174,7 +174,7 @@ jobs: echo "Success: Any output from GenerateEnums has already been committed." echo "exit 0" else - names=`git diff --name-only` + names=`git diff --name-status | awk '{print $2;}'` if [[ "$names" == "unicodetools/src/main/java/org/unicode/props/UcdPropertyValues.java" ]]; then gitdiffstat=`git diff --stat | tail -n 1` if [[ "$gitdiffstat" = "1 file changed, 1 insertion(+), 1 deletion(-)" ]]; then @@ -189,6 +189,9 @@ jobs: echo "Failure: GenerateEnums has changed that need to be committed." echo "exit 1" fi + # TODO(#100): Note: when running locally on a clean checkout, this command + # leaves a change in UcdPropertyValues.java by not preserving the comment + # about the fake Unicode version 13.1. env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 7a6d58746be5496b1a17b9745f6ea2e040f36ed6 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Fri, 6 May 2022 17:06:31 -0700 Subject: [PATCH 04/10] Debug git command issues --- .github/workflows/cli-build-instructions.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index c0ed4fe87..d6cc9042e 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -169,25 +169,26 @@ jobs: # TODO(#100) Get rid of need for fake version 13.1 of Unicode enum val # Fail if we haven't committed changes from Generate Enums, but make exception for fake Unicode version hack (#100) echo "Check if GenerateEnums output has been committed to repo" - git diff --compact-summary --exit-code - if [ $? -eq 0 ]; then + echo "git diff --compact-summary" + if git diff --compact-summary --exit-code; then echo "Success: Any output from GenerateEnums has already been committed." echo "exit 0" else + echo "git diff --name-status | awk '{print $2;}'" names=`git diff --name-status | awk '{print $2;}'` if [[ "$names" == "unicodetools/src/main/java/org/unicode/props/UcdPropertyValues.java" ]]; then gitdiffstat=`git diff --stat | tail -n 1` - if [[ "$gitdiffstat" = "1 file changed, 1 insertion(+), 1 deletion(-)" ]]; then + if [[ "$gitdiffstat" = " 1 file changed, 1 insertion(+), 1 deletion(-)" ]]; then git diff | grep 'V13_1("13.1")' if [ $? -eq 0 ]; then echo "Inferred: Only non-committed change after GenerateEnums is temporary V13_1 hack (issue #100)" echo "Check passed." - echo "exit 0" + exit 0 fi fi fi - echo "Failure: GenerateEnums has changed that need to be committed." - echo "exit 1" + echo "Failure: GenerateEnums has changes that need to be committed." + exit 1 fi # TODO(#100): Note: when running locally on a clean checkout, this command # leaves a change in UcdPropertyValues.java by not preserving the comment From 989e2ebece2bcca30ea00eb9a516f7023e777f15 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Tue, 10 May 2022 10:34:35 -0700 Subject: [PATCH 05/10] Add back CI job for GenerateConfusables --- .github/workflows/cli-build-instructions.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index d6cc9042e..3ab000633 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -196,3 +196,14 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # https://github.com/unicode-org/unicodetools/blob/main/docs/security.md#generating + - name: Run command - Generate Confusables + run: | + cd unicodetools/mine/src + # run GenerateConfusables + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.GenerateConfusables" -Dexec.args="-c -b" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + # run Build & Test command again to rerun TestSecurity test to verify output is okay + MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + From f52da727938c4107808ab0276e1916302156a456 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Wed, 11 May 2022 10:54:05 -0700 Subject: [PATCH 06/10] Only run the TestSecurity test to verify after GenerateConfusables is run --- .github/workflows/cli-build-instructions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 3ab000633..553e68219 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -203,7 +203,7 @@ jobs: # run GenerateConfusables mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.GenerateConfusables" -Dexec.args="-c -b" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 # run Build & Test command again to rerun TestSecurity test to verify output is okay - MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml test -pl unicodetools -Dtest=TestSecurity -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 11662a0769d5011793d5f12a37fd814cd3dfac30 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Wed, 11 May 2022 10:59:27 -0700 Subject: [PATCH 07/10] Minor typo fix --- .github/workflows/cli-build-instructions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 553e68219..3ef0ef305 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -172,7 +172,7 @@ jobs: echo "git diff --compact-summary" if git diff --compact-summary --exit-code; then echo "Success: Any output from GenerateEnums has already been committed." - echo "exit 0" + exit 0 else echo "git diff --name-status | awk '{print $2;}'" names=`git diff --name-status | awk '{print $2;}'` From 50ef316bf6ec4837c5dfb025f88491b3d0fb0412 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Wed, 11 May 2022 11:05:55 -0700 Subject: [PATCH 08/10] Remove superfluous commands --- .github/workflows/cli-build-instructions.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 3ef0ef305..f43a048fe 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -151,10 +151,6 @@ jobs: - name: Run command - Generate IDNA Test run: | cd unicodetools/mine/src - # Confirm that the directory for the bin files exists - compgen -G "../Generated/BIN" - # "Delete all the bin files" as per instructions - rm -rf ../Generated/BIN/* # run GenerateIdnaTest mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdnaTest" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 env: From 7470f345664524c445b7303c2311addd4768c267 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Wed, 11 May 2022 11:13:51 -0700 Subject: [PATCH 09/10] Define current Unicode version globally for entire workflow --- .github/workflows/cli-build-instructions.yml | 27 +++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index f43a048fe..32a7d8064 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -8,6 +8,9 @@ on: branches: - '*' +env: + CURRENT_UVERSION=15.0.0 + jobs: # Only run 1 or 2 commands for in-source build instructions, just to demonstrate @@ -48,12 +51,12 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Run command - Build and Test - run: MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../cldr ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd Generated; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + run: MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../cldr ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd Generated; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Run command - Make Unicode Files - run: MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version 15.0.0 build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../cldr ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd Generated; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + run: MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version $CURRENT_UVERSION build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../cldr ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd Generated; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -95,14 +98,14 @@ jobs: - name: Run command - Build and Test run: | cd unicodetools/mine/src - MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml package -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Run command - Make Unicode Files run: | cd unicodetools/mine/src - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version 15.0.0 build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version $CURRENT_UVERSION build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -110,7 +113,7 @@ jobs: - name: Run command - AAC Order run: | cd unicodetools/mine/src - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.tools.AacOrder" -Dexec.args="version 15.0.0 build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.tools.AacOrder" -Dexec.args="version $CURRENT_UVERSION build MakeUnicodeFiles" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -120,7 +123,7 @@ jobs: run: | cd unicodetools/mine/src # invoke main() in class ...UCA.Main - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCA.Main" -Dexec.args="writeCollationValidityLog" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCA.Main" -Dexec.args="writeCollationValidityLog" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION # check for output file compgen -G "../Generated/UCA/*/CheckCollationValidity.html" env: @@ -130,7 +133,7 @@ jobs: # run: | # cd unicodetools/mine/src # # invoke main() in class ...UCA.Main - # mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCA.Main" -Dexec.args="ICU" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + # mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCA.Main" -Dexec.args="ICU" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION # env: # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -143,7 +146,7 @@ jobs: # "Delete all the bin files" as per instructions rm -rf ../Generated/BIN/* # run GenerateIdna - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdna" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdna" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -152,7 +155,7 @@ jobs: run: | cd unicodetools/mine/src # run GenerateIdnaTest - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdnaTest" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.idna.GenerateIdnaTest" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -161,7 +164,7 @@ jobs: run: | cd unicodetools/mine/src # run GenerateEnums - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.props.GenerateEnums" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.props.GenerateEnums" -Dexec.args="" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION # TODO(#100) Get rid of need for fake version 13.1 of Unicode enum val # Fail if we haven't committed changes from Generate Enums, but make exception for fake Unicode version hack (#100) echo "Check if GenerateEnums output has been committed to repo" @@ -197,9 +200,9 @@ jobs: run: | cd unicodetools/mine/src # run GenerateConfusables - mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.GenerateConfusables" -Dexec.args="-c -b" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + mvn -s .github/workflows/mvn-settings.xml exec:java -Dexec.mainClass="org.unicode.text.UCD.GenerateConfusables" -Dexec.args="-c -b" -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION # run Build & Test command again to rerun TestSecurity test to verify output is okay - MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml test -pl unicodetools -Dtest=TestSecurity -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=15.0.0 + MAVEN_OPTS="-ea" mvn -s .github/workflows/mvn-settings.xml test -pl unicodetools -Dtest=TestSecurity -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From a2a2d4f36f898410a4052f4dd6776737c67dfa00 Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Wed, 11 May 2022 11:15:45 -0700 Subject: [PATCH 10/10] Fix typo --- .github/workflows/cli-build-instructions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cli-build-instructions.yml b/.github/workflows/cli-build-instructions.yml index 32a7d8064..c931386a5 100644 --- a/.github/workflows/cli-build-instructions.yml +++ b/.github/workflows/cli-build-instructions.yml @@ -9,7 +9,7 @@ on: - '*' env: - CURRENT_UVERSION=15.0.0 + CURRENT_UVERSION: 15.0.0 jobs: