jsp: move to Maven #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #30
srl295
commented
Feb 22, 2021
Comment on lines
+24
to
+29
| <icu.version>69.1-SNAPSHOT-cldr-2021-02-17</icu.version> | ||
|
|
||
| <!-- | ||
| For CLDR versions, see https://github.com/orgs/unicode-org/packages?repo_name=cldr | ||
| --> | ||
| <cldr.version>0.0.0-SNAPSHOT-87058620ea</cldr.version> |
There was a problem hiding this comment.
this controls the ICU and CLDR version used.
srl295
commented
Feb 22, 2021
Comment on lines
+75
to
+97
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>2.8.6</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>29.0-jre</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>xerces</groupId> | ||
| <artifactId>xercesImpl</artifactId> | ||
| <version>2.12.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>xml-apis</groupId> | ||
| <artifactId>xml-apis</artifactId> | ||
| <version>1.4.01</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
There was a problem hiding this comment.
copied these from CLDR latest, but these can be bumped as needed
interim instructions:
To debug with eclipse, there are instructions here, not tested yet https://www.eclipse.org/jetty/documentation/jetty-9/index.html#debugging-with-eclipse |
macchiati
approved these changes
Feb 22, 2021
This was referenced Feb 23, 2021
Merged
srl295
added a commit
that referenced
this pull request
Feb 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30