fix(emoji): 🙆‍♀️ 💪 Add appropriate error handling for getting the alias of a unicode value

unicodeveloper · unicodeveloper · commit 4d56f7aa7134 · 2016-02-08T05:50:09.000+01:00
diff --git a/src/Emoji.php b/src/Emoji.php
@@ -37,7 +37,7 @@ public function findByAlias($emojiName = null)
 
     public function findByName($emojiName = null)
     {
-        $this->findByAlias($emojiName);
+        return $this->findByAlias($emojiName);
     }
 
     public function findByUnicode($unicode = null)
@@ -46,9 +46,13 @@ public function findByUnicode($unicode = null)
             throw new \Exception("Please provide a valid UTF-8 Unicode value");
         }
 
-        $emoji = array_flip($this->getEmojis());
+        $emojis = array_flip($this->getEmojis());
 
-        return $emoji[$unicode];
+        if (! array_key_exists($unicode, $emojis)) {
+            throw new \Exception("Emoji Not Found, Man. Please provide a valid UTF-8 Unicode value");
+        }
+
+        return $emojis[$unicode];
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function findByAlias($emojiName = null)`
`37`	`37`
`38`	`38`	`public function findByName($emojiName = null)`
`39`	`39`	`{`
`40`		`- $this->findByAlias($emojiName);`
	`40`	`+ return $this->findByAlias($emojiName);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`public function findByUnicode($unicode = null)`
`@@ -46,9 +46,13 @@ public function findByUnicode($unicode = null)`
`46`	`46`	`throw new \Exception("Please provide a valid UTF-8 Unicode value");`
`47`	`47`	`}`
`48`	`48`
`49`		`- $emoji = array_flip($this->getEmojis());`
	`49`	`+ $emojis = array_flip($this->getEmojis());`
`50`	`50`
`51`		`- return $emoji[$unicode];`
	`51`	`+ if (! array_key_exists($unicode, $emojis)) {`
	`52`	`+ throw new \Exception("Emoji Not Found, Man. Please provide a valid UTF-8 Unicode value");`
	`53`	`+ }`
	`54`	`+`
	`55`	`+ return $emojis[$unicode];`
`52`	`56`	`}`
`53`	`57`
`54`	`58`	`}`