remove the flip altogether

jkudish · web-flow · commit 8bc3b4692dc6 · 2017-04-25T15:50:29.000-07:00
on second hand, we don't need the flip at all, can just swap `has` with `contains` instead, and good to go.
diff --git a/src/DumbPasswordServiceProvider.php b/src/DumbPasswordServiceProvider.php
@@ -30,10 +30,9 @@ public function boot()
     {
         $path = realpath(__DIR__.'/../resources/config/passwordlist.txt');
         $dumbPasswords = collect(explode("\n", file_get_contents($path)));
-        $data = $dumbPasswords->flip();
 
         Validator::extend('dumbpwd', function ($attribute, $value, $parameters, $validator) use ($data) {
-            return !$data->has($value);
+            return !$data->contains($value);
         }, $this->message);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,9 @@ public function boot()`
`30`	`30`	`{`
`31`	`31`	`$path = realpath(__DIR__.'/../resources/config/passwordlist.txt');`
`32`	`32`	`$dumbPasswords = collect(explode("\n", file_get_contents($path)));`
`33`		`- $data = $dumbPasswords->flip();`
`34`	`33`
`35`	`34`	`Validator::extend('dumbpwd', function ($attribute, $value, $parameters, $validator) use ($data) {`
`36`		`- return !$data->has($value);`
	`35`	`+ return !$data->contains($value);`
`37`	`36`	`}, $this->message);`
`38`	`37`	`}`
`39`	`38`